Title: [232617] trunk/Websites/perf.webkit.org
- Revision
- 232617
- Author
- [email protected]
- Date
- 2018-06-07 23:02:47 -0700 (Thu, 07 Jun 2018)
Log Message
Related task may not have a metric or platform.
https://bugs.webkit.org/show_bug.cgi?id=186426
Reviewed by Ryosuke Niwa.
Related task in the related task list can be a custom analysis task which
may not have platform or metric.
* public/v3/pages/analysis-task-page.js: Added null checks for platform and metric.
(AnalysisTaskPage.prototype._renderRelatedTasks):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (232616 => 232617)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-06-08 05:14:03 UTC (rev 232616)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-06-08 06:02:47 UTC (rev 232617)
@@ -1,5 +1,18 @@
2018-06-07 Dewei Zhu <[email protected]>
+ Related task may not have a metric or platform.
+ https://bugs.webkit.org/show_bug.cgi?id=186426
+
+ Reviewed by Ryosuke Niwa.
+
+ Related task in the related task list can be a custom analysis task which
+ may not have platform or metric.
+
+ * public/v3/pages/analysis-task-page.js: Added null checks for platform and metric.
+ (AnalysisTaskPage.prototype._renderRelatedTasks):
+
+2018-06-07 Dewei Zhu <[email protected]>
+
Fix browser test failed assertions and a bug in 'common-component-base'
https://bugs.webkit.org/show_bug.cgi?id=186423
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (232616 => 232617)
--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2018-06-08 05:14:03 UTC (rev 232616)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2018-06-08 06:02:47 UTC (rev 232617)
@@ -704,9 +704,9 @@
this.renderReplace(this.content('related-tasks-list'), (task && relatedTasks ? relatedTasks : []).map((otherTask) => {
let suffix = '';
const taskLabel = otherTask.label();
- if (otherTask.metric() != task.metric() && taskLabel.indexOf(otherTask.metric().label()) < 0)
+ if (otherTask.metric() && otherTask.metric() != task.metric() && taskLabel.indexOf(otherTask.metric().label()) < 0)
suffix += ` with "${otherTask.metric().label()}"`;
- if (otherTask.platform() != task.platform() && taskLabel.indexOf(otherTask.platform().label()) < 0)
+ if (otherTask.platform() && otherTask.platform() != task.platform() && taskLabel.indexOf(otherTask.platform().label()) < 0)
suffix += ` on ${otherTask.platform().label()}`;
return element('li', [link(taskLabel, this.router().url(`analysis/task/${otherTask.id()}`)), suffix]);
}));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
