Title: [232644] trunk/Source/ThirdParty/libwebrtc
- Revision
- 232644
- Author
- [email protected]
- Date
- 2018-06-08 15:30:23 -0700 (Fri, 08 Jun 2018)
Log Message
[Cocoa] Minor ARC tidying of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186396
Reviewed by Dan Bernstein.
* Configurations/Base.xcconfig: Set CLANG_ENABLE_OBJC_ARC here as we will eventually be
doing in all the various Base.xcconfig files as we make progress on conversion.
* Configurations/libwebrtc.xcconfig: Removed override of CLANG_ENABLE_OBJC_ARC here and
also removed five other redundant settings that match Base.xcconfig.
* libwebrtc.xcodeproj/project.pbxproj: Removed explicit -fobjc-arc that was set on
one particular source file, since that's already the default for the project.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (232643 => 232644)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-06-08 22:29:26 UTC (rev 232643)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-06-08 22:30:23 UTC (rev 232644)
@@ -1,3 +1,19 @@
+2018-06-07 Darin Adler <[email protected]>
+
+ [Cocoa] Minor ARC tidying of libwebrtc
+ https://bugs.webkit.org/show_bug.cgi?id=186396
+
+ Reviewed by Dan Bernstein.
+
+ * Configurations/Base.xcconfig: Set CLANG_ENABLE_OBJC_ARC here as we will eventually be
+ doing in all the various Base.xcconfig files as we make progress on conversion.
+
+ * Configurations/libwebrtc.xcconfig: Removed override of CLANG_ENABLE_OBJC_ARC here and
+ also removed five other redundant settings that match Base.xcconfig.
+
+ * libwebrtc.xcodeproj/project.pbxproj: Removed explicit -fobjc-arc that was set on
+ one particular source file, since that's already the default for the project.
+
2018-06-04 Youenn Fablet <[email protected]>
[WK1] Add an option to restrict communication to localhost sockets
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (232643 => 232644)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig 2018-06-08 22:29:26 UTC (rev 232643)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig 2018-06-08 22:30:23 UTC (rev 232644)
@@ -9,6 +9,7 @@
CLANG_CXX_LANGUAGE_STANDARD = gnu++14;
CLANG_CXX_LIBRARY = libc++;
+CLANG_ENABLE_OBJC_ARC = YES;
CLANG_ENABLE_OBJC_WEAK = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (232643 => 232644)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2018-06-08 22:29:26 UTC (rev 232643)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2018-06-08 22:30:23 UTC (rev 232644)
@@ -17,14 +17,7 @@
DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_ = $(DYLIB_INSTALL_NAME_BASE);
DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_YES = @loader_path/../../../;
-CLANG_ENABLE_OBJC_ARC = YES;
-
-CLANG_WARN_BOOL_CONVERSION = YES;
-CLANG_WARN_ENUM_CONVERSION = YES;
-CLANG_WARN_INT_CONVERSION = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
-COMBINE_HIDPI_IMAGES = NO;
-ENABLE_STRICT_OBJC_MSGSEND = YES;
HEADER_SEARCH_PATHS = Source Source/third_party/jsoncpp/source/include Source/third_party/libsrtp/crypto/include Source/third_party/libsrtp/include Source/third_party/boringssl/src/include Source/third_party/libyuv/include Source/third_party/usrsctp/usrsctplib Source/third_party/usrsctp/usrsctplib/usrsctplib Source/webrtc/sdk/objc/Framework/Headers Source/webrtc/common_audio/signal_processing/include Source/webrtc/modules/audio_coding/codecs/isac/main/include Source/third_party/opus/src/celt Source/third_party/opus/src/include Source/third_party/opus/src/src Source/webrtc/modules/audio_device/mac Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet Source/webrtc/modules/audio_device/ios;
PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/libwebrtc;
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (232643 => 232644)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-06-08 22:29:26 UTC (rev 232643)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-06-08 22:30:23 UTC (rev 232644)
@@ -2745,7 +2745,7 @@
5CFD537C1E4BA4F500482908 /* audio_device_ios.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53751E4BA4F500482908 /* audio_device_ios.h */; };
5CFD53801E4BA4F500482908 /* audio_session_observer.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD53791E4BA4F500482908 /* audio_session_observer.h */; };
5CFD53811E4BA4F500482908 /* voice_processing_audio_unit.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CFD537A1E4BA4F500482908 /* voice_processing_audio_unit.h */; };
- 5CFD53821E4BA4F500482908 /* voice_processing_audio_unit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD537B1E4BA4F500482908 /* voice_processing_audio_unit.mm */; settings = {COMPILER_FLAGS = "-fobjc-arc"; }; };
+ 5CFD53821E4BA4F500482908 /* voice_processing_audio_unit.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD537B1E4BA4F500482908 /* voice_processing_audio_unit.mm */; };
5CFD538D1E4BD3A300482908 /* compare_neon.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53851E4BD3A300482908 /* compare_neon.cc */; };
5CFD538E1E4BD3A300482908 /* compare_neon64.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53861E4BD3A300482908 /* compare_neon64.cc */; };
5CFD538F1E4BD3A300482908 /* rotate_neon.cc in Sources */ = {isa = PBXBuildFile; fileRef = 5CFD53871E4BD3A300482908 /* rotate_neon.cc */; };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
