Title: [232649] trunk/Source/WebCore
Revision
232649
Author
[email protected]
Date
2018-06-08 16:26:21 -0700 (Fri, 08 Jun 2018)

Log Message

'setRenderPipelineState:' is unavailable: not available on iOS
https://bugs.webkit.org/show_bug.cgi?id=186449
<rdar://problem/40880602>

Reviewed by Simon Fraser.

Be more explicit about the protocol type to avoid
the compiler getting confused by a similar signature.

* platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm:
(WebCore::GPURenderCommandEncoder::setRenderPipelineState):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (232648 => 232649)


--- trunk/Source/WebCore/ChangeLog	2018-06-08 23:18:47 UTC (rev 232648)
+++ trunk/Source/WebCore/ChangeLog	2018-06-08 23:26:21 UTC (rev 232649)
@@ -1,3 +1,17 @@
+2018-06-08  Dean Jackson  <[email protected]>
+
+        'setRenderPipelineState:' is unavailable: not available on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=186449
+        <rdar://problem/40880602>
+
+        Reviewed by Simon Fraser.
+
+        Be more explicit about the protocol type to avoid
+        the compiler getting confused by a similar signature.
+
+        * platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm:
+        (WebCore::GPURenderCommandEncoder::setRenderPipelineState):
+
 2018-06-08  Darin Adler  <[email protected]>
 
         Fix iOS build.

Modified: trunk/Source/WebCore/platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm (232648 => 232649)


--- trunk/Source/WebCore/platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm	2018-06-08 23:18:47 UTC (rev 232648)
+++ trunk/Source/WebCore/platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm	2018-06-08 23:26:21 UTC (rev 232649)
@@ -54,7 +54,9 @@
     if (!m_renderCommandEncoder || !renderPipelineState)
         return;
 
-    [m_renderCommandEncoder setRenderPipelineState:static_cast<id<MTLRenderPipelineState>>(renderPipelineState->platformRenderPipelineState())];
+    // We need to cast to MTLRenderCommandEncoder explicitly because the compiler gets
+    // confused by a protocol with a similar signature.
+    [(id<MTLRenderCommandEncoder>)m_renderCommandEncoder.get() setRenderPipelineState:static_cast<id<MTLRenderPipelineState>>(renderPipelineState->platformRenderPipelineState())];
 }
 
 void GPURenderCommandEncoder::setDepthStencilState(GPUDepthStencilState* depthStencilState)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to