Title: [232722] trunk/Source/WebKit
- Revision
- 232722
- Author
- n_w...@apple.com
- Date
- 2018-06-11 11:11:23 -0700 (Mon, 11 Jun 2018)
Log Message
AX: [iOS] accessibility sometimes doesn't know process suspension is canceled
https://bugs.webkit.org/show_bug.cgi?id=186450
Reviewed by Chris Fleizach.
There's some early return condition in WebProcess::cancelPrepareToSuspend() which
could lead to accessibility failing to post process status notificaiton. Fixed it
by moving the accessibility notification before the early return condition.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::cancelPrepareToSuspend):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (232721 => 232722)
--- trunk/Source/WebKit/ChangeLog 2018-06-11 17:24:58 UTC (rev 232721)
+++ trunk/Source/WebKit/ChangeLog 2018-06-11 18:11:23 UTC (rev 232722)
@@ -1,3 +1,17 @@
+2018-06-11 Nan Wang <n_w...@apple.com>
+
+ AX: [iOS] accessibility sometimes doesn't know process suspension is canceled
+ https://bugs.webkit.org/show_bug.cgi?id=186450
+
+ Reviewed by Chris Fleizach.
+
+ There's some early return condition in WebProcess::cancelPrepareToSuspend() which
+ could lead to accessibility failing to post process status notificaiton. Fixed it
+ by moving the accessibility notification before the early return condition.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::cancelPrepareToSuspend):
+
2018-06-10 Carlos Garcia Campos <cgar...@igalia.com>
[GTK][WPE] Add API run run _javascript_ from a WebKitWebView in an isolated world
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (232721 => 232722)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2018-06-11 17:24:58 UTC (rev 232721)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2018-06-11 18:11:23 UTC (rev 232722)
@@ -1412,6 +1412,10 @@
RELEASE_LOG(ProcessSuspension, "%p - WebProcess::cancelPrepareToSuspend()", this);
setAllLayerTreeStatesFrozen(false);
+#if PLATFORM(IOS)
+ accessibilityProcessSuspendedNotification(false);
+#endif
+
// If we've already finished cleaning up and sent ProcessReadyToSuspend, we
// shouldn't send DidCancelProcessSuspension; the UI process strictly expects one or the other.
if (!m_pageMarkingLayersAsVolatileCounter)
@@ -1418,10 +1422,6 @@
return;
cancelMarkAllLayersVolatile();
-
-#if PLATFORM(IOS)
- accessibilityProcessSuspendedNotification(false);
-#endif
RELEASE_LOG(ProcessSuspension, "%p - WebProcess::cancelPrepareToSuspend() Sending DidCancelProcessSuspension IPC message", this);
parentProcessConnection()->send(Messages::WebProcessProxy::DidCancelProcessSuspension(), 0);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
