Title: [101217] trunk/Source/_javascript_Core
- Revision
- 101217
- Author
- [email protected]
- Date
- 2011-11-27 18:11:58 -0800 (Sun, 27 Nov 2011)
Log Message
DFG should not emit GetMethod node
https://bugs.webkit.org/show_bug.cgi?id=73175
Reviewed by Gavin Barraclough.
Replaces all instances of the GetMethod node with GetById. This appears to
be a slight win on V8. This patch leaves GetMethod support in the code-base,
making this decision easy to reverse, for now.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101216 => 101217)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-28 00:12:54 UTC (rev 101216)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-28 02:11:58 UTC (rev 101217)
@@ -1,3 +1,17 @@
+2011-11-27 Filip Pizlo <[email protected]>
+
+ DFG should not emit GetMethod node
+ https://bugs.webkit.org/show_bug.cgi?id=73175
+
+ Reviewed by Gavin Barraclough.
+
+ Replaces all instances of the GetMethod node with GetById. This appears to
+ be a slight win on V8. This patch leaves GetMethod support in the code-base,
+ making this decision easy to reverse, for now.
+
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::parseBlock):
+
2011-11-26 Hajime Morrita <[email protected]>
Needs WTF_INLINE and JS_INLINE
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (101216 => 101217)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-11-28 00:12:54 UTC (rev 101216)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-11-28 02:11:58 UTC (rev 101217)
@@ -1653,10 +1653,8 @@
addToGraph(CheckStructure, OpInfo(m_graph.addStructureSet(methodCall.cachedPrototypeStructure.get())), cellConstant(methodCall.cachedPrototype.get()));
set(getInstruction[1].u.operand, cellConstant(methodCall.cachedFunction.get()));
- } else {
- NodeIndex getMethod = addToGraph(GetMethod, OpInfo(identifier), OpInfo(prediction), base);
- set(getInstruction[1].u.operand, getMethod);
- }
+ } else
+ set(getInstruction[1].u.operand, addToGraph(GetById, OpInfo(identifier), OpInfo(prediction), base));
m_currentIndex += OPCODE_LENGTH(op_method_check) + OPCODE_LENGTH(op_get_by_id);
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
