Title: [232810] trunk/LayoutTests
Revision
232810
Author
mark....@apple.com
Date
2018-06-13 14:21:21 -0700 (Wed, 13 Jun 2018)

Log Message

Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=186372

Not reviewed.

Speculative fix to green the bots plus improved the error message logging to get
more info if this fails again. 

* js/error-should-not-strong-reference-global-object.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (232809 => 232810)


--- trunk/LayoutTests/ChangeLog	2018-06-13 20:57:49 UTC (rev 232809)
+++ trunk/LayoutTests/ChangeLog	2018-06-13 21:21:21 UTC (rev 232810)
@@ -1,3 +1,15 @@
+2018-06-13  Mark Lam  <mark....@apple.com>
+
+        Gardening: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=186372
+
+        Not reviewed.
+
+        Speculative fix to green the bots plus improved the error message logging to get
+        more info if this fails again. 
+
+        * js/error-should-not-strong-reference-global-object.html:
+
 2018-06-13  Timothy Hatcher  <timo...@apple.com>
 
         Input form controls have a white background in dark mode, when they should not.

Modified: trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html (232809 => 232810)


--- trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html	2018-06-13 20:57:49 UTC (rev 232809)
+++ trunk/LayoutTests/js/error-should-not-strong-reference-global-object.html	2018-06-13 21:21:21 UTC (rev 232810)
@@ -40,10 +40,13 @@
 for (let i = 0; i < 50; i++)
     run();
 
-$vm.gc();
-// We shouldn't have more than 10% of the global objects we allocated.
-if ($vm.globalObjectCount() >= 51)
-    throw new Error("There are more global objects than there should be");
+setTimeout(() => {
+    $vm.gc();
+    // We shouldn't have more than 10% of the global objects we allocated.
+    var globalObjectCount = $vm.globalObjectCount();
+    if (globalObjectCount >= 51)
+        throw new Error("There are more global objects than there should be: actual count = " + globalObjectCount);
+}, 1);
 
 </script>
 <script src=""
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to