Title: [232846] trunk/Source/ThirdParty/libwebrtc
Revision
232846
Author
[email protected]
Date
2018-06-14 11:04:34 -0700 (Thu, 14 Jun 2018)

Log Message

Eliminate static initializers in libwebrtc.dylib
https://bugs.webkit.org/show_bug.cgi?id=186570
<rdar://problem/41054874>

Reviewed by Darin Adler.

* Source/webrtc/rtc_base/flags.h:
Fix memory corruption error by having the actual flag value be static.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (232845 => 232846)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-06-14 18:02:43 UTC (rev 232845)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-06-14 18:04:34 UTC (rev 232846)
@@ -1,3 +1,14 @@
+2018-06-14  Youenn Fablet  <[email protected]>
+
+        Eliminate static initializers in libwebrtc.dylib
+        https://bugs.webkit.org/show_bug.cgi?id=186570
+        <rdar://problem/41054874>
+
+        Reviewed by Darin Adler.
+
+        * Source/webrtc/rtc_base/flags.h:
+        Fix memory corruption error by having the actual flag value be static.
+
 2018-06-13  Youenn Fablet  <[email protected]>
 
         Eliminate static initializers in libwebrtc.dylib

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h (232845 => 232846)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h	2018-06-14 18:02:43 UTC (rev 232845)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h	2018-06-14 18:04:34 UTC (rev 232846)
@@ -155,7 +155,7 @@
 #define DEFINE_FLAG(type, c_type, name, default, comment)    \
   static std::pair<std::reference_wrapper<c_type>, std::reference_wrapper<rtc::Flag>> name() { \
     /* define and initialize the flag */                     \
-    c_type FLAG_##name = (default);                          \
+    static c_type FLAG_##name = (default);                   \
     /* register the flag */                                  \
     static rtc::Flag Flag_##name(__FILE__, #name, (comment), \
       rtc::Flag::type, &FLAG_##name,                         \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to