Title: [232959] trunk/Source/WebCore
- Revision
- 232959
- Author
- [email protected]
- Date
- 2018-06-19 07:02:27 -0700 (Tue, 19 Jun 2018)
Log Message
Add logging when splashboardd enables WebThread
<https://webkit.org/b/186793>
<rdar://problem/41213255>
Reviewed by Daniel Bates.
* platform/RuntimeApplicationChecks.h:
(WebCore::IOSApplication::isSplashBoardd): Add declaration.
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isSplashBoardd): Add implementation.
* platform/ios/wak/WebCoreThread.mm:
(WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
splashboardd.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (232958 => 232959)
--- trunk/Source/WebCore/ChangeLog 2018-06-19 12:05:19 UTC (rev 232958)
+++ trunk/Source/WebCore/ChangeLog 2018-06-19 14:02:27 UTC (rev 232959)
@@ -1,3 +1,19 @@
+2018-06-19 David Kilzer <[email protected]>
+
+ Add logging when splashboardd enables WebThread
+ <https://webkit.org/b/186793>
+ <rdar://problem/41213255>
+
+ Reviewed by Daniel Bates.
+
+ * platform/RuntimeApplicationChecks.h:
+ (WebCore::IOSApplication::isSplashBoardd): Add declaration.
+ * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+ (WebCore::IOSApplication::isSplashBoardd): Add implementation.
+ * platform/ios/wak/WebCoreThread.mm:
+ (WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
+ splashboardd.
+
2018-06-19 Miguel Gomez <[email protected]>
[GTK][WPE][Nicosia] Add environment variable to enable threaded rendering and set the number of painting threads
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (232958 => 232959)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2018-06-19 12:05:19 UTC (rev 232958)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2018-06-19 14:02:27 UTC (rev 232959)
@@ -78,6 +78,7 @@
WEBCORE_EXPORT bool isWebBookmarksD();
bool isDumpRenderTree();
bool isMobileStore();
+bool isSplashBoardd();
bool isSpringBoard();
WEBCORE_EXPORT bool isWebApp();
WEBCORE_EXPORT bool isWebProcess();
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (232958 => 232959)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2018-06-19 12:05:19 UTC (rev 232958)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2018-06-19 14:02:27 UTC (rev 232959)
@@ -206,6 +206,12 @@
return isMobileStore;
}
+bool IOSApplication::isSplashBoardd()
+{
+ static bool isSplashBoardd = applicationBundleIsEqualTo(ASCIILiteral("splashboardd"));
+ return isSplashBoardd;
+}
+
bool IOSApplication::isSpringBoard()
{
static bool isSpringBoard = applicationBundleIsEqualTo(ASCIILiteral("com.apple.springboard"));
Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (232958 => 232959)
--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2018-06-19 12:05:19 UTC (rev 232958)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2018-06-19 14:02:27 UTC (rev 232959)
@@ -866,7 +866,9 @@
void WebThreadEnable(void)
{
RELEASE_ASSERT_WITH_MESSAGE(!WebCore::IOSApplication::isWebProcess(), "The WebProcess should never run a Web Thread");
- if (WebCore::IOSApplication::isSpringBoard())
+ if (WebCore::IOSApplication::isSplashBoardd())
+ RELEASE_LOG_FAULT(Threading, "splashboardd enabled WebThread.");
+ else if (WebCore::IOSApplication::isSpringBoard())
RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
static std::once_flag flag;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
