Title: [233064] trunk/Tools
- Revision
- 233064
- Author
- [email protected]
- Date
- 2018-06-21 15:51:00 -0700 (Thu, 21 Jun 2018)
Log Message
EWS for security bugs
https://bugs.webkit.org/show_bug.cgi?id=186291
<rdar://problem/40829658>
Substitute webkit.status-api-key for webkit.status_api_key as Git configuration variables can
only consist of alphanumeric characters and underscores (_) per the second paragraph of section
Configuration File of <https://git-scm.com/docs/git-config/2.18.0#_configuration_file>:
The variable names are case-insensitive, allow only alphanumeric characters and -, and must
start with an alphabetic character.
* Scripts/webkitpy/tool/main.py:
(WebKitPatch._status_server_api_key_from_git):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233063 => 233064)
--- trunk/Tools/ChangeLog 2018-06-21 22:32:12 UTC (rev 233063)
+++ trunk/Tools/ChangeLog 2018-06-21 22:51:00 UTC (rev 233064)
@@ -4,6 +4,22 @@
https://bugs.webkit.org/show_bug.cgi?id=186291
<rdar://problem/40829658>
+ Substitute webkit.status-api-key for webkit.status_api_key as Git configuration variables can
+ only consist of alphanumeric characters and underscores (_) per the second paragraph of section
+ Configuration File of <https://git-scm.com/docs/git-config/2.18.0#_configuration_file>:
+
+ The variable names are case-insensitive, allow only alphanumeric characters and -, and must
+ start with an alphabetic character.
+
+ * Scripts/webkitpy/tool/main.py:
+ (WebKitPatch._status_server_api_key_from_git):
+
+2018-06-21 Daniel Bates <[email protected]>
+
+ EWS for security bugs
+ https://bugs.webkit.org/show_bug.cgi?id=186291
+ <rdar://problem/40829658>
+
In r232979, I inadvertently removed a line of code in _parse_authorized_api_keys() to define a local called api_keys.
Add this code back.
Modified: trunk/Tools/Scripts/webkitpy/tool/main.py (233063 => 233064)
--- trunk/Tools/Scripts/webkitpy/tool/main.py 2018-06-21 22:32:12 UTC (rev 233063)
+++ trunk/Tools/Scripts/webkitpy/tool/main.py 2018-06-21 22:51:00 UTC (rev 233064)
@@ -98,7 +98,7 @@
try:
if not Git.in_working_directory(os.getcwd()):
return None
- return Git.read_git_config('webkit.status_api_key')
+ return Git.read_git_config('webkit.status-api-key')
except OSError as e:
# Catch and ignore OSError exceptions such as "no such file
# or directory" (OSError errno 2), which imply that the Git
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
