Title: [233076] trunk/Source/WebCore
- Revision
- 233076
- Author
- [email protected]
- Date
- 2018-06-22 06:22:13 -0700 (Fri, 22 Jun 2018)
Log Message
[CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
https://bugs.webkit.org/show_bug.cgi?id=186911
Reviewed by Michael Catanzaro.
This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
didn't start a clean build. The problem is that the CMake command to generate
SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
SelectorPseudoClassAndCompatibilityElementMap.in.
* CMakeLists.txt:
Modified Paths
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (233075 => 233076)
--- trunk/Source/WebCore/CMakeLists.txt 2018-06-22 09:49:55 UTC (rev 233075)
+++ trunk/Source/WebCore/CMakeLists.txt 2018-06-22 13:22:13 UTC (rev 233076)
@@ -1740,7 +1740,8 @@
# Generate CSS Selector pseudo type name to value maps.
add_custom_command(
OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp
- MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
+ MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in
+ DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
VERBATIM)
@@ -1747,7 +1748,8 @@
list(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp)
add_custom_command(
OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.cpp
- MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
+ MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in
+ DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
VERBATIM)
Modified: trunk/Source/WebCore/ChangeLog (233075 => 233076)
--- trunk/Source/WebCore/ChangeLog 2018-06-22 09:49:55 UTC (rev 233075)
+++ trunk/Source/WebCore/ChangeLog 2018-06-22 13:22:13 UTC (rev 233076)
@@ -1,3 +1,17 @@
+2018-06-22 Carlos Garcia Campos <[email protected]>
+
+ [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
+ https://bugs.webkit.org/show_bug.cgi?id=186911
+
+ Reviewed by Michael Catanzaro.
+
+ This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
+ didn't start a clean build. The problem is that the CMake command to generate
+ SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
+ SelectorPseudoClassAndCompatibilityElementMap.in.
+
+ * CMakeLists.txt:
+
2018-06-22 Miguel Gomez <[email protected]>
[WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
