Title: [233080] trunk
- Revision
- 233080
- Author
- [email protected]
- Date
- 2018-06-22 08:43:45 -0700 (Fri, 22 Jun 2018)
Log Message
REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
https://bugs.webkit.org/show_bug.cgi?id=186206
Source/WebCore:
Unreviewed manual rollout of r230950
* platform/graphics/texmap/TextureMapperLayer.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
Source/WebKit:
Unreviewed manual rollout of r230950
* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::layerShouldHaveBackingStore):
LayoutTests:
Unreviewed, remove crash expectations for crashes introduced by r230950.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233079 => 233080)
--- trunk/LayoutTests/ChangeLog 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/LayoutTests/ChangeLog 2018-06-22 15:43:45 UTC (rev 233080)
@@ -1,3 +1,12 @@
+2018-06-22 Michael Catanzaro <[email protected]>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed, remove crash expectations for crashes introduced by r230950.
+
+ * platform/gtk/TestExpectations:
+
2018-06-21 David Fenton <[email protected]>
Skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (233079 => 233080)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-06-22 15:43:45 UTC (rev 233080)
@@ -1282,8 +1282,6 @@
webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ]
-webkit.org/b/185910 media/video-duration-known-after-eos.html [ Crash Pass ]
-
# Crashes only when GNOME icon theme is not installed
webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
@@ -1615,8 +1613,7 @@
webkit.org/b/133865 media/W3C/video/networkState/networkState_during_progress.html [ Failure Pass ]
webkit.org/b/133866 media/media-controls-cancel-events.html [ Timeout Failure Pass ]
webkit.org/b/133867 webaudio/audioprocessingevent.html [ Failure Pass ]
-# Crash is webkit.org/b/186206
-webkit.org/b/133869 media/video-seek-after-end.html [ Failure Crash ]
+webkit.org/b/133869 media/video-seek-after-end.html [ Failure ]
# Crash is webkit.org/b/176802
webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass Crash ]
Modified: trunk/Source/WebCore/ChangeLog (233079 => 233080)
--- trunk/Source/WebCore/ChangeLog 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/Source/WebCore/ChangeLog 2018-06-22 15:43:45 UTC (rev 233080)
@@ -1,3 +1,14 @@
+2018-06-22 Michael Catanzaro <[email protected]>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed manual rollout of r230950
+
+ * platform/graphics/texmap/TextureMapperLayer.h:
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+ (WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
+
2018-06-20 Darin Adler <[email protected]>
[Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (233079 => 233080)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2018-06-22 15:43:45 UTC (rev 233080)
@@ -88,7 +88,6 @@
void setRepaintCount(int);
void setContentsLayer(TextureMapperPlatformLayer*);
void setAnimations(const TextureMapperAnimations&);
- const TextureMapperAnimations& animations() const { return m_animations; }
void setBackingStore(TextureMapperBackingStore*);
bool applyAnimationsRecursively(MonotonicTime);
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (233079 => 233080)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp 2018-06-22 15:43:45 UTC (rev 233080)
@@ -1084,8 +1084,7 @@
bool CoordinatedGraphicsLayer::shouldHaveBackingStore() const
{
- return drawsContent() && contentsAreVisible() && !m_size.isEmpty()
- && (!!opacity() || m_animations.hasActiveAnimationsOfType(AnimatedPropertyOpacity));
+ return drawsContent() && contentsAreVisible() && !m_size.isEmpty();
}
bool CoordinatedGraphicsLayer::selfOrAncestorHasActiveTransformAnimation() const
Modified: trunk/Source/WebKit/ChangeLog (233079 => 233080)
--- trunk/Source/WebKit/ChangeLog 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/Source/WebKit/ChangeLog 2018-06-22 15:43:45 UTC (rev 233080)
@@ -1,3 +1,13 @@
+2018-06-22 Michael Catanzaro <[email protected]>
+
+ REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
+ https://bugs.webkit.org/show_bug.cgi?id=186206
+
+ Unreviewed manual rollout of r230950
+
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+ (WebKit::layerShouldHaveBackingStore):
+
2018-06-20 Darin Adler <[email protected]>
[Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (233079 => 233080)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-06-22 15:03:54 UTC (rev 233079)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2018-06-22 15:43:45 UTC (rev 233080)
@@ -37,8 +37,7 @@
static bool layerShouldHaveBackingStore(TextureMapperLayer* layer)
{
- return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty()
- && (!!layer->opacity() || layer->animations().hasActiveAnimationsOfType(AnimatedPropertyOpacity));
+ return layer->drawsContent() && layer->contentsAreVisible() && !layer->size().isEmpty();
}
CoordinatedGraphicsScene::CoordinatedGraphicsScene(CoordinatedGraphicsSceneClient* client)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
