Title: [233096] trunk/Source/WebKit
- Revision
- 233096
- Author
- [email protected]
- Date
- 2018-06-22 13:32:36 -0700 (Fri, 22 Jun 2018)
Log Message
[Cocoa] REGRESSION(W3C): actions for key equivalents are not respected
https://bugs.webkit.org/show_bug.cgi?id=186936
Reviewed by Timothy Hatcher.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::isSimulatingUserInteraction const):
This erroneously reported false unless there was both a mouse and key interaction
being dispatched, which is not possible in the current serial event simulation model.
As a result, Safari could not tell whether the action came from a simulated event
or the user, and thus rejected all key equivalents like Cmd-A,V,C,X.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233095 => 233096)
--- trunk/Source/WebKit/ChangeLog 2018-06-22 20:24:55 UTC (rev 233095)
+++ trunk/Source/WebKit/ChangeLog 2018-06-22 20:32:36 UTC (rev 233096)
@@ -1,3 +1,17 @@
+2018-06-22 Brian Burg <[email protected]>
+
+ [Cocoa] REGRESSION(W3C): actions for key equivalents are not respected
+ https://bugs.webkit.org/show_bug.cgi?id=186936
+
+ Reviewed by Timothy Hatcher.
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::isSimulatingUserInteraction const):
+ This erroneously reported false unless there was both a mouse and key interaction
+ being dispatched, which is not possible in the current serial event simulation model.
+ As a result, Safari could not tell whether the action came from a simulated event
+ or the user, and thus rejected all key equivalents like Cmd-A,V,C,X.
+
2018-06-22 Jer Noble <[email protected]>
[Fullscreen] Exit fullscreen when opening a new tab
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (233095 => 233096)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-06-22 20:24:55 UTC (rev 233095)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2018-06-22 20:32:36 UTC (rev 233096)
@@ -1411,11 +1411,11 @@
bool WebAutomationSession::isSimulatingUserInteraction() const
{
if (!m_pendingMouseEventsFlushedCallbacksPerPage.isEmpty())
- return false;
+ return true;
if (!m_pendingKeyboardEventsFlushedCallbacksPerPage.isEmpty())
- return false;
+ return true;
- return true;
+ return false;
}
SimulatedInputDispatcher& WebAutomationSession::inputDispatcherForPage(WebPageProxy& page)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
