Title: [233118] trunk/Source/WebKit
Revision
233118
Author
[email protected]
Date
2018-06-22 18:31:42 -0700 (Fri, 22 Jun 2018)

Log Message

Regression(r230211): Crash under WebInspectorClient::~WebInspectorClient()
https://bugs.webkit.org/show_bug.cgi?id=186950
<rdar://problem/40602069>

Reviewed by Darin Adler.

Re-introduce null-check that was accidentally dropped in r230211.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::~WebInspectorClient):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (233117 => 233118)


--- trunk/Source/WebKit/ChangeLog	2018-06-23 01:22:04 UTC (rev 233117)
+++ trunk/Source/WebKit/ChangeLog	2018-06-23 01:31:42 UTC (rev 233118)
@@ -1,3 +1,16 @@
+2018-06-22  Chris Dumez  <[email protected]>
+
+        Regression(r230211): Crash under WebInspectorClient::~WebInspectorClient()
+        https://bugs.webkit.org/show_bug.cgi?id=186950
+        <rdar://problem/40602069>
+
+        Reviewed by Darin Adler.
+
+        Re-introduce null-check that was accidentally dropped in r230211.
+
+        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+        (WebKit::WebInspectorClient::~WebInspectorClient):
+
 2018-06-22  Timothy Hatcher  <[email protected]>
 
         Corner of two scroll bars is white with dark mode enabled.

Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp (233117 => 233118)


--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp	2018-06-23 01:22:04 UTC (rev 233117)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp	2018-06-23 01:31:42 UTC (rev 233118)
@@ -72,7 +72,7 @@
         delete layer;
     }
 
-    if (m_paintRectOverlay)
+    if (m_paintRectOverlay && m_page->corePage())
         m_page->corePage()->pageOverlayController().uninstallPageOverlay(*m_paintRectOverlay, PageOverlay::FadeMode::Fade);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to