Title: [233139] trunk/Source/_javascript_Core
- Revision
- 233139
- Author
- [email protected]
- Date
- 2018-06-25 02:26:22 -0700 (Mon, 25 Jun 2018)
Log Message
[JSC] Remove unnecessary PLATFORM guards
https://bugs.webkit.org/show_bug.cgi?id=186995
Reviewed by Mark Lam.
* assembler/AssemblerCommon.h:
(JSC::isIOS):
Add constexpr.
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
StackFrame works in all the platforms. If StackFrame::demangle failed,
it just returns std::nullopt. And it is correctly handled in this code.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (233138 => 233139)
--- trunk/Source/_javascript_Core/ChangeLog 2018-06-25 07:05:51 UTC (rev 233138)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-06-25 09:26:22 UTC (rev 233139)
@@ -1,3 +1,19 @@
+2018-06-25 Yusuke Suzuki <[email protected]>
+
+ [JSC] Remove unnecessary PLATFORM guards
+ https://bugs.webkit.org/show_bug.cgi?id=186995
+
+ Reviewed by Mark Lam.
+
+ * assembler/AssemblerCommon.h:
+ (JSC::isIOS):
+ Add constexpr.
+
+ * inspector/JSGlobalObjectInspectorController.cpp:
+ (Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
+ StackFrame works in all the platforms. If StackFrame::demangle failed,
+ it just returns std::nullopt. And it is correctly handled in this code.
+
2018-06-23 Mark Lam <[email protected]>
Add more debugging features to $vm.
Modified: trunk/Source/_javascript_Core/assembler/AssemblerCommon.h (233138 => 233139)
--- trunk/Source/_javascript_Core/assembler/AssemblerCommon.h 2018-06-25 07:05:51 UTC (rev 233138)
+++ trunk/Source/_javascript_Core/assembler/AssemblerCommon.h 2018-06-25 09:26:22 UTC (rev 233139)
@@ -27,7 +27,7 @@
namespace JSC {
-ALWAYS_INLINE bool isIOS()
+ALWAYS_INLINE constexpr bool isIOS()
{
#if PLATFORM(IOS)
return true;
Modified: trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp (233138 => 233139)
--- trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp 2018-06-25 07:05:51 UTC (rev 233138)
+++ trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp 2018-06-25 09:26:22 UTC (rev 233139)
@@ -180,7 +180,6 @@
void JSGlobalObjectInspectorController::appendAPIBacktrace(ScriptCallStack& callStack)
{
-#if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK))
static const int framesToShow = 31;
static const int framesToSkip = 3; // WTFGetBacktrace, appendAPIBacktrace, reportAPIException.
@@ -197,9 +196,6 @@
else
callStack.append(ScriptCallFrame("?"_s, "[native code]"_s, noSourceID, 0, 0));
}
-#else
- UNUSED_PARAM(callStack);
-#endif
}
void JSGlobalObjectInspectorController::reportAPIException(ExecState* exec, Exception* exception)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
