Title: [233181] trunk/Source/WebKit
- Revision
- 233181
- Author
- timothy_hor...@apple.com
- Date
- 2018-06-25 16:40:52 -0700 (Mon, 25 Jun 2018)
Log Message
WKThumbnailView fallback background is blindingly bright in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=187017
<rdar://problem/41036209>
Reviewed by Simon Fraser.
* UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView initWithFrame:]):
(-[_WKThumbnailView wantsUpdateLayer]):
(-[_WKThumbnailView updateLayer]):
Use a semantic color for the WKThumbnailView background color
instead of flat white.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233180 => 233181)
--- trunk/Source/WebKit/ChangeLog 2018-06-25 23:37:39 UTC (rev 233180)
+++ trunk/Source/WebKit/ChangeLog 2018-06-25 23:40:52 UTC (rev 233181)
@@ -1,3 +1,18 @@
+2018-06-25 Tim Horton <timothy_hor...@apple.com>
+
+ WKThumbnailView fallback background is blindingly bright in Dark Mode
+ https://bugs.webkit.org/show_bug.cgi?id=187017
+ <rdar://problem/41036209>
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/API/Cocoa/_WKThumbnailView.mm:
+ (-[_WKThumbnailView initWithFrame:]):
+ (-[_WKThumbnailView wantsUpdateLayer]):
+ (-[_WKThumbnailView updateLayer]):
+ Use a semantic color for the WKThumbnailView background color
+ instead of flat white.
+
2018-06-25 John Wilander <wilan...@apple.com>
Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm (233180 => 233181)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm 2018-06-25 23:37:39 UTC (rev 233180)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm 2018-06-25 23:40:52 UTC (rev 233181)
@@ -70,7 +70,6 @@
return nil;
self.wantsLayer = YES;
- self.layer.backgroundColor = [NSColor whiteColor].CGColor;
_scale = 1;
_lastSnapshotScale = NAN;
@@ -103,6 +102,18 @@
return self;
}
+- (BOOL)wantsUpdateLayer
+{
+ return YES;
+}
+
+- (void)updateLayer
+{
+ [super updateLayer];
+
+ self.layer.backgroundColor = [NSColor quaternaryLabelColor].CGColor;
+}
+
- (void)requestSnapshot
{
if (_waitingForSnapshot) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
