Title: [233316] trunk/Source/WebKit
- Revision
- 233316
- Author
- [email protected]
- Date
- 2018-06-28 12:14:47 -0700 (Thu, 28 Jun 2018)
Log Message
Web Inspector: REGRESSION(r223770): "Open Link" context menu action on a linkified URL doesn't work
https://bugs.webkit.org/show_bug.cgi?id=187146
<rdar://problem/41369591>
Reviewed by Joseph Pecoraro.
When Web Inspector's page receives a navigation request, it's supposed to redirect any
non-Inspector navigations to be loaded in the inspected page. When I refactored to use
modern a policy delegate, the one line that redirects the loads was left out.
No new tests, because inspector tests can't navigate the inspector or inspected pages.
* UIProcess/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233315 => 233316)
--- trunk/Source/WebKit/ChangeLog 2018-06-28 18:51:07 UTC (rev 233315)
+++ trunk/Source/WebKit/ChangeLog 2018-06-28 19:14:47 UTC (rev 233316)
@@ -1,3 +1,20 @@
+2018-06-28 Brian Burg <[email protected]>
+
+ Web Inspector: REGRESSION(r223770): "Open Link" context menu action on a linkified URL doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=187146
+ <rdar://problem/41369591>
+
+ Reviewed by Joseph Pecoraro.
+
+ When Web Inspector's page receives a navigation request, it's supposed to redirect any
+ non-Inspector navigations to be loaded in the inspected page. When I refactored to use
+ modern a policy delegate, the one line that redirects the loads was left out.
+
+ No new tests, because inspector tests can't navigate the inspector or inspected pages.
+
+ * UIProcess/mac/WKInspectorViewController.mm:
+ (-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
+
2018-06-28 Jeremy Jones <[email protected]>
Crash when _topConstraint is null in element fullscreen.
Modified: trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm (233315 => 233316)
--- trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm 2018-06-28 18:51:07 UTC (rev 233315)
+++ trunk/Source/WebKit/UIProcess/mac/WKInspectorViewController.mm 2018-06-28 19:14:47 UTC (rev 233316)
@@ -225,6 +225,9 @@
// Prevent everything else.
decisionHandler(WKNavigationActionPolicyCancel);
+
+ // And instead load it in the inspected page.
+ _inspectedPage->loadRequest(navigationAction.request);
}
// MARK: WKInspectorWKWebViewDelegate methods
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
