Title: [233330] trunk/Tools
- Revision
- 233330
- Author
- [email protected]
- Date
- 2018-06-28 14:54:26 -0700 (Thu, 28 Jun 2018)
Log Message
Try to address test failures on the bots.
Allow the test to distinguish between a failure to find the variable, and an error
reporting vector capacity.
* lldb/lldb_webkit_unittest.py:
(TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
(TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233329 => 233330)
--- trunk/Tools/ChangeLog 2018-06-28 21:48:45 UTC (rev 233329)
+++ trunk/Tools/ChangeLog 2018-06-28 21:54:26 UTC (rev 233330)
@@ -1,3 +1,14 @@
+2018-06-28 Simon Fraser <[email protected]>
+
+ Try to address test failures on the bots.
+
+ Allow the test to distinguish between a failure to find the variable, and an error
+ reporting vector capacity.
+
+ * lldb/lldb_webkit_unittest.py:
+ (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
+ (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
+
2018-06-28 Lucas Forschler <[email protected]>
Add Windows support for WEBKIT_API_KEY.
Modified: trunk/Tools/lldb/lldb_webkit_unittest.py (233329 => 233330)
--- trunk/Tools/lldb/lldb_webkit_unittest.py 2018-06-28 21:48:45 UTC (rev 233329)
+++ trunk/Tools/lldb/lldb_webkit_unittest.py 2018-06-28 21:54:26 UTC (rev 233330)
@@ -142,9 +142,13 @@
# MARK: WTFVector_SummaryProvider test cases
def serial_test_WTFVectorProvider_empty_vector(self):
- summary = lldb_webkit.WTFVector_SummaryProvider(self._sbFrame.FindVariable('anEmptyVector'), {})
+ variable = self._sbFrame.FindVariable('anEmptyVector');
+ self.assertIsNotNone(variable)
+ summary = lldb_webkit.WTFVector_SummaryProvider(variable, {})
self.assertEqual(summary, "{ size = 0, capacity = 0 }")
def serial_test_WTFVectorProvider_vector_size_and_capacity(self):
- summary = lldb_webkit.WTFVector_SummaryProvider(self._sbFrame.FindVariable('aVectorWithOneItem'), {})
+ variable = self._sbFrame.FindVariable('aVectorWithOneItem');
+ self.assertIsNotNone(variable)
+ summary = lldb_webkit.WTFVector_SummaryProvider(variable, {})
self.assertEqual(summary, "{ size = 1, capacity = 16 }")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
