Title: [233407] trunk/Tools
- Revision
- 233407
- Author
- [email protected]
- Date
- 2018-06-30 23:00:27 -0700 (Sat, 30 Jun 2018)
Log Message
test-webkitpy never rebuilds lldbWebKitTester
https://bugs.webkit.org/show_bug.cgi?id=187229
Reviewed by David Kilzer.
Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
exist in the build products directory for the active configuration (e.g. Debug); => we do not
build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
that we have an up-to-date build of lldbWebKitTester.
* Scripts/webkitpy/test/main.py:
(Tester._run_tests):
(_find_lldb_webkit_tester): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233406 => 233407)
--- trunk/Tools/ChangeLog 2018-07-01 02:12:26 UTC (rev 233406)
+++ trunk/Tools/ChangeLog 2018-07-01 06:00:27 UTC (rev 233407)
@@ -1,3 +1,22 @@
+2018-06-30 Daniel Bates <[email protected]>
+
+ test-webkitpy never rebuilds lldbWebKitTester
+ https://bugs.webkit.org/show_bug.cgi?id=187229
+
+ Reviewed by David Kilzer.
+
+ Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
+
+ Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
+ exist in the build products directory for the active configuration (e.g. Debug); => we do not
+ build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
+ Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
+ that we have an up-to-date build of lldbWebKitTester.
+
+ * Scripts/webkitpy/test/main.py:
+ (Tester._run_tests):
+ (_find_lldb_webkit_tester): Deleted.
+
2018-06-30 Michael Catanzaro <[email protected]>
[CMake] build-webkit should be able to enable address sanitizer
Modified: trunk/Tools/Scripts/webkitpy/test/main.py (233406 => 233407)
--- trunk/Tools/Scripts/webkitpy/test/main.py 2018-07-01 02:12:26 UTC (rev 233406)
+++ trunk/Tools/Scripts/webkitpy/test/main.py 2018-07-01 06:00:27 UTC (rev 233407)
@@ -52,12 +52,6 @@
_webkit_root = None
-def _find_lldb_webkit_tester():
- config = Config(_host.executive, _host.filesystem)
- lldb_webkit_tester_executable = os.path.join(config.build_directory(config.default_configuration()), 'lldbWebKitTester')
- return os.path.isfile(lldb_webkit_tester_executable) and os.access(lldb_webkit_tester_executable, os.X_OK)
-
-
def _build_lldb_webkit_tester():
if not _host.platform.is_mac():
_log.error('lldbWebKitTester is not supported on this platform.')
@@ -194,12 +188,10 @@
autoinstall_everything()
if will_run_lldb_webkit_tests:
- self.printer.write_update("Checking lldbWebKitTester ...")
- if not _find_lldb_webkit_tester():
- self.printer.write_update("Building lldbWebKitTester ...")
- if not _build_lldb_webkit_tester():
- _log.error('Failed to build lldbWebKitTester.')
- return False
+ self.printer.write_update('Building lldbWebKitTester ...')
+ if not _build_lldb_webkit_tester():
+ _log.error('Failed to build lldbWebKitTester.')
+ return False
if self._options.coverage:
_log.warning("Checking code coverage, so running things serially")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
