Title: [233429] trunk/Source/WebCore
- Revision
- 233429
- Author
- [email protected]
- Date
- 2018-07-02 13:45:29 -0700 (Mon, 02 Jul 2018)
Log Message
[Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
https://bugs.webkit.org/show_bug.cgi?id=187139
Reviewed by Dean Jackson.
Ensure we have a resolved time value before trying to use it.
* animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233428 => 233429)
--- trunk/Source/WebCore/ChangeLog 2018-07-02 19:02:18 UTC (rev 233428)
+++ trunk/Source/WebCore/ChangeLog 2018-07-02 20:45:29 UTC (rev 233429)
@@ -1,3 +1,15 @@
+2018-07-02 Antoine Quint <[email protected]>
+
+ [Web Animations] Crash in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
+ https://bugs.webkit.org/show_bug.cgi?id=187139
+
+ Reviewed by Dean Jackson.
+
+ Ensure we have a resolved time value before trying to use it.
+
+ * animation/KeyframeEffectReadOnly.cpp:
+ (WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):
+
2018-07-02 Youenn Fablet <[email protected]>
Reject getUserMedia promise if capture fails
Modified: trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp (233428 => 233429)
--- trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp 2018-07-02 19:02:18 UTC (rev 233428)
+++ trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp 2018-07-02 20:45:29 UTC (rev 233429)
@@ -1243,7 +1243,11 @@
auto* compositedRenderer = downcast<RenderBoxModelObject>(renderer);
- auto timeOffset = animation()->currentTime().value().seconds();
+ auto currentTime = animation()->currentTime();
+ if (!currentTime)
+ return;
+
+ auto timeOffset = currentTime->seconds();
if (timing()->delay() < 0_s)
timeOffset = -timing()->delay().seconds();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
