Title: [233438] trunk/Tools
- Revision
- 233438
- Author
- beid...@apple.com
- Date
- 2018-07-02 15:02:30 -0700 (Mon, 02 Jul 2018)
Log Message
Another unreviewed followup to:
Crash notifying observers of responsiveness state change
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
test on iOS for other reasons.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233437 => 233438)
--- trunk/Tools/ChangeLog 2018-07-02 21:59:47 UTC (rev 233437)
+++ trunk/Tools/ChangeLog 2018-07-02 22:02:30 UTC (rev 233438)
@@ -1,5 +1,15 @@
2018-07-02 Brady Eidson <beid...@apple.com>
+ Another unreviewed followup to:
+ Crash notifying observers of responsiveness state change
+
+ * TestWebKitAPI/cocoa/TestWKWebView.h:
+ * TestWebKitAPI/cocoa/TestWKWebView.mm:
+ (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
+ test on iOS for other reasons.
+
+2018-07-02 Brady Eidson <beid...@apple.com>
+
Unreviewed followup to:
Crash notifying observers of responsiveness state change
Modified: trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h (233437 => 233438)
--- trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h 2018-07-02 21:59:47 UTC (rev 233437)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.h 2018-07-02 22:02:30 UTC (rev 233438)
@@ -57,7 +57,6 @@
- (void)waitForMessage:(NSString *)message;
- (void)performAfterLoading:(dispatch_block_t)actions;
- (void)waitForNextPresentationUpdate;
-- (void)typeCharacter:(char)character;
@end
#if PLATFORM(IOS)
@@ -76,6 +75,7 @@
- (void)mouseMoveToPoint:(NSPoint)point withFlags:(NSEventModifierFlags)flags;
- (void)sendClicksAtPoint:(NSPoint)point numberOfClicks:(NSUInteger)numberOfClicks;
- (NSWindow *)hostWindow;
+- (void)typeCharacter:(char)character;
@end
#endif
Modified: trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm (233437 => 233438)
--- trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm 2018-07-02 21:59:47 UTC (rev 233437)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm 2018-07-02 22:02:30 UTC (rev 233438)
@@ -311,14 +311,6 @@
TestWebKitAPI::Util::run(&done);
}
-- (void)typeCharacter:(char)character {
- NSString *characterAsString = [NSString stringWithFormat:@"%c" , character];
- NSEventType keyDownEventType = NSEventTypeKeyDown;
- NSEventType keyUpEventType = NSEventTypeKeyUp;
- [self keyDown:[NSEvent keyEventWithType:keyDownEventType location:NSZeroPoint modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[_hostWindow windowNumber] context:nil characters:characterAsString charactersIgnoringModifiers:characterAsString isARepeat:NO keyCode:character]];
- [self keyUp:[NSEvent keyEventWithType:keyUpEventType location:NSZeroPoint modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[_hostWindow windowNumber] context:nil characters:characterAsString charactersIgnoringModifiers:characterAsString isARepeat:NO keyCode:character]];
-}
-
@end
#if PLATFORM(IOS)
@@ -391,6 +383,15 @@
{
return _hostWindow.get();
}
+
+- (void)typeCharacter:(char)character {
+ NSString *characterAsString = [NSString stringWithFormat:@"%c" , character];
+ NSEventType keyDownEventType = NSEventTypeKeyDown;
+ NSEventType keyUpEventType = NSEventTypeKeyUp;
+ [self keyDown:[NSEvent keyEventWithType:keyDownEventType location:NSZeroPoint modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[_hostWindow windowNumber] context:nil characters:characterAsString charactersIgnoringModifiers:characterAsString isARepeat:NO keyCode:character]];
+ [self keyUp:[NSEvent keyEventWithType:keyUpEventType location:NSZeroPoint modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[_hostWindow windowNumber] context:nil characters:characterAsString charactersIgnoringModifiers:characterAsString isARepeat:NO keyCode:character]];
+}
+
@end
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
