Title: [233442] trunk/Source/WebCore
Revision
233442
Author
[email protected]
Date
2018-07-02 15:47:20 -0700 (Mon, 02 Jul 2018)

Log Message

HTML widget displays blank when playing on page
https://bugs.webkit.org/show_bug.cgi?id=187272
<rdar://problem/39317899>

Reviewed by Simon Fraser.

When a composited layer gains content (in this particular case, going from NoContentsLayer to ContentsLayerForMedia),
we need to size the associated graphics layer accordingly (NoContentsLayer means zero sized graphics layer).

Not testable on iOS.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (233441 => 233442)


--- trunk/Source/WebCore/ChangeLog	2018-07-02 22:27:42 UTC (rev 233441)
+++ trunk/Source/WebCore/ChangeLog	2018-07-02 22:47:20 UTC (rev 233442)
@@ -1,3 +1,19 @@
+2018-07-02  Zalan Bujtas  <[email protected]>
+
+        HTML widget displays blank when playing on page
+        https://bugs.webkit.org/show_bug.cgi?id=187272
+        <rdar://problem/39317899>
+
+        Reviewed by Simon Fraser.
+
+        When a composited layer gains content (in this particular case, going from NoContentsLayer to ContentsLayerForMedia),
+        we need to size the associated graphics layer accordingly (NoContentsLayer means zero sized graphics layer).  
+
+        Not testable on iOS.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateConfiguration):
+
 2018-07-02  David Kilzer  <[email protected]>
 
         Refactor InlineTextBox::emphasisMarkExistsAndIsAbove()

Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (233441 => 233442)


--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2018-07-02 22:27:42 UTC (rev 233441)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2018-07-02 22:47:20 UTC (rev 233442)
@@ -752,6 +752,7 @@
     else if (is<RenderVideo>(renderer()) && downcast<RenderVideo>(renderer()).shouldDisplayVideo()) {
         auto* mediaElement = downcast<HTMLMediaElement>(renderer().element());
         m_graphicsLayer->setContentsToPlatformLayer(mediaElement->platformLayer(), GraphicsLayer::ContentsLayerForMedia);
+        resetContentsRect();
     }
 #endif
 #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to