Title: [233448] trunk/Tools
Revision
233448
Author
wenson_hs...@apple.com
Date
2018-07-02 17:17:54 -0700 (Mon, 02 Jul 2018)

Log Message

Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
https://bugs.webkit.org/show_bug.cgi?id=187280

Reviewed by Tim Horton.

Add a missing `adoptNS()`.

* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (233447 => 233448)


--- trunk/Tools/ChangeLog	2018-07-03 00:15:20 UTC (rev 233447)
+++ trunk/Tools/ChangeLog	2018-07-03 00:17:54 UTC (rev 233448)
@@ -1,3 +1,15 @@
+2018-07-02  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
+        https://bugs.webkit.org/show_bug.cgi?id=187280
+
+        Reviewed by Tim Horton.
+
+        Add a missing `adoptNS()`.
+
+        * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
+        (TestWebKitAPI::TEST):
+
 2018-07-02  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed

Modified: trunk/Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm (233447 => 233448)


--- trunk/Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm	2018-07-03 00:15:20 UTC (rev 233447)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm	2018-07-03 00:17:54 UTC (rev 233448)
@@ -96,7 +96,7 @@
     UIApplicationInitialize();
 
     auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
-    auto window = [[TestWKWebViewControllerWindow alloc] initWithFrame:CGRectMake(0, 0, 1024, 768)];
+    auto window = adoptNS([[TestWKWebViewControllerWindow alloc] initWithFrame:CGRectMake(0, 0, 1024, 768)]);
     auto rootViewController = adoptNS([[UIViewController alloc] init]);
     auto navigationController = adoptNS([[UINavigationController alloc] initWithRootViewController:rootViewController.get()]);
     auto observer = adoptNS([[ActionSheetObserver alloc] init]);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to