[webkit-changes] [233476] trunk/Source/WebCore

[commit-queue]

Title: [233476] trunk/Source/WebCore

Revision

233476

Author

commit-qu...@webkit.org

Date

2018-07-03 13:50:04 -0700 (Tue, 03 Jul 2018)

Log Message

Unreviewed, rolling out r233112.
https://bugs.webkit.org/show_bug.cgi?id=187300

this revision is causing crashes on iOS 11 simulator
(Requested by Truitt on #webkit).

Reverted changeset:

"[Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit
fullscreen handler after r231924"
https://bugs.webkit.org/show_bug.cgi?id=186945
https://trac.webkit.org/changeset/233112

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

Diff

Modified: trunk/Source/WebCore/ChangeLog (233475 => 233476)

--- trunk/Source/WebCore/ChangeLog	2018-07-03 20:46:38 UTC (rev 233475)
+++ trunk/Source/WebCore/ChangeLog	2018-07-03 20:50:04 UTC (rev 233476)
@@ -1,3 +1,18 @@
+2018-07-03  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r233112.
+        https://bugs.webkit.org/show_bug.cgi?id=187300
+
+        this revision is causing crashes on iOS 11 simulator
+        (Requested by Truitt on #webkit).
+
+        Reverted changeset:
+
+        "[Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit
+        fullscreen handler after r231924"
+        https://bugs.webkit.org/show_bug.cgi?id=186945
+        https://trac.webkit.org/changeset/233112
+
 2018-07-03  Chris Dumez  <cdu...@apple.com>
 
         Implement support for Element.toggleAttribute

Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (233475 => 233476)

--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm	2018-07-03 20:46:38 UTC (rev 233475)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm	2018-07-03 20:50:04 UTC (rev 233476)
@@ -1011,10 +1011,8 @@
         }];
     } else if (m_currentMode.isFullscreen()) {
         [m_playerViewController exitFullScreenAnimated:YES completionHandler:[protectedThis = makeRefPtr(this), this] (BOOL success, NSError* error) mutable {
-            if (!success) {
+            if (!success)
                 WTFLogAlways("-[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error %s", [[error localizedDescription] UTF8String]);
-                ASSERT_NOT_REACHED();
-            }
 
             m_exitCompleted = true;
 
@@ -1049,10 +1047,8 @@
     if (m_currentMode.hasFullscreen()) {
         [[m_playerViewController view] layoutIfNeeded];
         [m_playerViewController exitFullScreenAnimated:NO completionHandler:[] (BOOL success, NSError* error) {
-            if (!success) {
+            if (!success)
                 WTFLogAlways("-[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error %s", [[error localizedDescription] UTF8String]);
-                ASSERT_NOT_REACHED();
-            }
         }];
     }
     
@@ -1794,10 +1790,8 @@
 
 void VideoFullscreenInterfaceAVKit::exitFullscreenHandler(BOOL success, NSError* error)
 {
-    if (!success) {
+    if (!success)
         WTFLogAlways("-[AVPlayerViewController exitFullScreenAnimated:completionHandler:] failed with error %s", [[error localizedDescription] UTF8String]);
-        ASSERT_NOT_REACHED();
-    }
 
     LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::didExitFullscreen(%p) - %d", this, success);
 

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes