Title: [233492] trunk
- Revision
- 233492
- Author
- [email protected]
- Date
- 2018-07-03 18:56:08 -0700 (Tue, 03 Jul 2018)
Log Message
Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html
https://bugs.webkit.org/show_bug.cgi?id=187243
Reviewed by Chris Dumez.
Source/WebKit:
In case a caches object has an engine, it uses the engine to get the salt.
In case engine/caches are non persistent, no salt was set for the engine, hence the crashes.
Add an empty salt whenever initializing a non-persistent engine to remove the crash.
Covered by updated expectations for two tests.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::initialize):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233491 => 233492)
--- trunk/LayoutTests/ChangeLog 2018-07-04 00:24:50 UTC (rev 233491)
+++ trunk/LayoutTests/ChangeLog 2018-07-04 01:56:08 UTC (rev 233492)
@@ -1,3 +1,12 @@
+2018-07-03 Youenn Fablet <[email protected]>
+
+ Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html
+ https://bugs.webkit.org/show_bug.cgi?id=187243
+
+ Reviewed by Chris Dumez.
+
+ * TestExpectations:
+
2018-07-03 Chris Dumez <[email protected]>
performance-api/performance-observer-no-document-leak.html is flaky
Modified: trunk/LayoutTests/TestExpectations (233491 => 233492)
--- trunk/LayoutTests/TestExpectations 2018-07-04 00:24:50 UTC (rev 233491)
+++ trunk/LayoutTests/TestExpectations 2018-07-04 01:56:08 UTC (rev 233492)
@@ -386,8 +386,6 @@
# End platform-specific tests.
#//////////////////////////////////////////////////////////////////////////////////////////
-webkit.org/b/187243 http/tests/cache-storage/cache-persistency.https.html [ Crash ]
-
# media/video-seek-after-end.html is flaky
webkit.org/b/116293 media/video-seek-after-end.html [ Pass Failure ]
@@ -2024,7 +2022,7 @@
webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Pass Timeout ]
-webkit.org/b/182928 http/tests/cache-storage/cache-representation.https.html [ Pass Failure Crash ]
+webkit.org/b/182928 http/tests/cache-storage/cache-representation.https.html [ Pass Failure ]
webkit.org/b/116621 fast/replaced/preferred-widths.html [ Pass Failure ]
Modified: trunk/Source/WebKit/ChangeLog (233491 => 233492)
--- trunk/Source/WebKit/ChangeLog 2018-07-04 00:24:50 UTC (rev 233491)
+++ trunk/Source/WebKit/ChangeLog 2018-07-04 01:56:08 UTC (rev 233492)
@@ -1,5 +1,21 @@
2018-07-03 Youenn Fablet <[email protected]>
+ Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html
+ https://bugs.webkit.org/show_bug.cgi?id=187243
+
+ Reviewed by Chris Dumez.
+
+ In case a caches object has an engine, it uses the engine to get the salt.
+ In case engine/caches are non persistent, no salt was set for the engine, hence the crashes.
+ Add an empty salt whenever initializing a non-persistent engine to remove the crash.
+
+ Covered by updated expectations for two tests.
+
+ * NetworkProcess/cache/CacheStorageEngine.cpp:
+ (WebKit::CacheStorage::Engine::initialize):
+
+2018-07-03 Youenn Fablet <[email protected]>
+
Fix regression introduced in r233335
https://bugs.webkit.org/show_bug.cgi?id=187282
Modified: trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp (233491 => 233492)
--- trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2018-07-04 00:24:50 UTC (rev 233491)
+++ trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp 2018-07-04 01:56:08 UTC (rev 233492)
@@ -290,6 +290,7 @@
}
if (!shouldPersist()) {
+ m_salt = NetworkCache::Salt { };
callback(std::nullopt);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
