Title: [233495] trunk
- Revision
- 233495
- Author
- [email protected]
- Date
- 2018-07-03 20:18:55 -0700 (Tue, 03 Jul 2018)
Log Message
[cairo] Doesn't paint box-shadow with zero blur-radius
https://bugs.webkit.org/show_bug.cgi?id=187244
Reviewed by Žan Doberšek.
Source/WebCore:
Cairo::ShadowState::isRequired() returned false if blur-radius is
zero.
No new tests (Covered by existing tests).
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::ShadowState::isRequired const): Do not check blur
is zero.
LayoutTests:
* platform/gtk/fast/box-shadow/inset-expected.png: Updated.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233494 => 233495)
--- trunk/LayoutTests/ChangeLog 2018-07-04 03:14:42 UTC (rev 233494)
+++ trunk/LayoutTests/ChangeLog 2018-07-04 03:18:55 UTC (rev 233495)
@@ -1,3 +1,12 @@
+2018-07-03 Fujii Hironori <[email protected]>
+
+ [cairo] Doesn't paint box-shadow with zero blur-radius
+ https://bugs.webkit.org/show_bug.cgi?id=187244
+
+ Reviewed by Žan Doberšek.
+
+ * platform/gtk/fast/box-shadow/inset-expected.png: Updated.
+
2018-07-03 Youenn Fablet <[email protected]>
Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html
Modified: trunk/LayoutTests/platform/gtk/fast/box-shadow/inset-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (233494 => 233495)
--- trunk/Source/WebCore/ChangeLog 2018-07-04 03:14:42 UTC (rev 233494)
+++ trunk/Source/WebCore/ChangeLog 2018-07-04 03:18:55 UTC (rev 233495)
@@ -1,3 +1,19 @@
+2018-07-03 Fujii Hironori <[email protected]>
+
+ [cairo] Doesn't paint box-shadow with zero blur-radius
+ https://bugs.webkit.org/show_bug.cgi?id=187244
+
+ Reviewed by Žan Doberšek.
+
+ Cairo::ShadowState::isRequired() returned false if blur-radius is
+ zero.
+
+ No new tests (Covered by existing tests).
+
+ * platform/graphics/cairo/CairoOperations.cpp:
+ (WebCore::Cairo::ShadowState::isRequired const): Do not check blur
+ is zero.
+
2018-07-03 Ryosuke Niwa <[email protected]>
Add a release assert to diagnose infinite recursions in removeAllEventListeners()
Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp (233494 => 233495)
--- trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2018-07-04 03:14:42 UTC (rev 233494)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp 2018-07-04 03:18:55 UTC (rev 233495)
@@ -612,8 +612,7 @@
bool ShadowState::isRequired(PlatformContextCairo& platformContext) const
{
- // We can't avoid ShadowBlur if the shadow has blur.
- if (color.isVisible() && blur)
+ if (color.isVisible())
return true;
// We can avoid ShadowBlur and optimize, since we're not drawing on a
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
