Title: [233499] trunk/Source/WebKit
- Revision
- 233499
- Author
- [email protected]
- Date
- 2018-07-04 00:43:20 -0700 (Wed, 04 Jul 2018)
Log Message
50 failing WebDriver tests after r233417
https://bugs.webkit.org/show_bug.cgi?id=187263
Patch by Carlos Garcia Campos <[email protected]> on 2018-07-04
Reviewed by Frédéric Wang.
A std::optional value is used while being std::nullopt. This is because the wrong input source is used when
transitioning keyboard input states.
* UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233498 => 233499)
--- trunk/Source/WebKit/ChangeLog 2018-07-04 03:45:50 UTC (rev 233498)
+++ trunk/Source/WebKit/ChangeLog 2018-07-04 07:43:20 UTC (rev 233499)
@@ -1,3 +1,16 @@
+2018-07-04 Carlos Garcia Campos <[email protected]>
+
+ 50 failing WebDriver tests after r233417
+ https://bugs.webkit.org/show_bug.cgi?id=187263
+
+ Reviewed by Frédéric Wang.
+
+ A std::optional value is used while being std::nullopt. This is because the wrong input source is used when
+ transitioning keyboard input states.
+
+ * UIProcess/Automation/SimulatedInputDispatcher.cpp:
+ (WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
+
2018-07-03 Youenn Fablet <[email protected]>
Remove quarantine for Webex plugin
Modified: trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp (233498 => 233499)
--- trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-07-04 03:45:50 UTC (rev 233498)
+++ trunk/Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp 2018-07-04 07:43:20 UTC (rev 233499)
@@ -270,7 +270,7 @@
if (!a.pressedCharKey && b.pressedCharKey)
m_client.simulateKeyboardInteraction(m_page, KeyboardInteraction::KeyPress, b.pressedCharKey.value(), WTFMove(eventDispatchFinished));
else if (a.pressedCharKey && !b.pressedCharKey)
- m_client.simulateKeyboardInteraction(m_page, KeyboardInteraction::KeyRelease, b.pressedCharKey.value(), WTFMove(eventDispatchFinished));
+ m_client.simulateKeyboardInteraction(m_page, KeyboardInteraction::KeyRelease, a.pressedCharKey.value(), WTFMove(eventDispatchFinished));
else if (a.pressedVirtualKeys != b.pressedVirtualKeys) {
for (VirtualKey key : b.pressedVirtualKeys) {
if (!a.pressedVirtualKeys.contains(key))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
