Title: [233506] trunk/Source/ThirdParty/libwebrtc
Revision
233506
Author
[email protected]
Date
2018-07-04 08:47:22 -0700 (Wed, 04 Jul 2018)

Log Message

[libwebrtc] Allow IP mismatch for local connections on localhost
https://bugs.webkit.org/show_bug.cgi?id=187302

Patch by Thibault Saunier <[email protected]> on 2018-07-04
Reviewed by Youenn Fablet.

The rest of the code allows it, but there was an unecessary assert

* Source/webrtc/p2p/base/tcpport.cc:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (233505 => 233506)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-07-04 14:17:34 UTC (rev 233505)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-07-04 15:47:22 UTC (rev 233506)
@@ -1,3 +1,14 @@
+2018-07-04  Thibault Saunier  <[email protected]>
+
+        [libwebrtc] Allow IP mismatch for local connections on localhost
+        https://bugs.webkit.org/show_bug.cgi?id=187302
+
+        Reviewed by Youenn Fablet.
+
+        The rest of the code allows it, but there was an unecessary assert
+
+        * Source/webrtc/p2p/base/tcpport.cc:
+
 2018-06-26  Yusuke Suzuki  <[email protected]>
 
         [GTK][WPE] Remove gflags from libwebrtc build

Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcpport.cc (233505 => 233506)


--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcpport.cc	2018-07-04 14:17:34 UTC (rev 233505)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcpport.cc	2018-07-04 15:47:22 UTC (rev 233506)
@@ -343,9 +343,9 @@
         << ", port() Network:" << port->Network()->ToString();
     const std::vector<rtc::InterfaceAddress>& desired_addresses =
         port_->Network()->GetIPs();
-    RTC_DCHECK(std::find(desired_addresses.begin(), desired_addresses.end(),
-                         socket_->GetLocalAddress().ipaddr()) !=
-               desired_addresses.end());
+    RTC_DCHECK(socket->GetLocalAddress().IsLoopbackIP() ||
+        std::find(desired_addresses.begin(), desired_addresses.end(),
+        socket_->GetLocalAddress().ipaddr()) != desired_addresses.end());
     ConnectSocketSignals(socket);
   }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to