Title: [233519] trunk
- Revision
- 233519
- Author
- [email protected]
- Date
- 2018-07-05 07:56:13 -0700 (Thu, 05 Jul 2018)
Log Message
[Web Animations] The ready promise should initially be resolved
https://bugs.webkit.org/show_bug.cgi?id=187341
<rdar://problem/41844711>
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Mark WPT progressions.
* web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt:
Source/WebCore:
The Web Animations spec mandates that the ready promise is initially resolved.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::WebAnimation):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (233518 => 233519)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-07-05 14:56:13 UTC (rev 233519)
@@ -1,3 +1,17 @@
+2018-07-05 Antoine Quint <[email protected]>
+
+ [Web Animations] The ready promise should initially be resolved
+ https://bugs.webkit.org/show_bug.cgi?id=187341
+ <rdar://problem/41844711>
+
+ Reviewed by Dean Jackson.
+
+ Mark WPT progressions.
+
+ * web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt:
+ * web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
+ * web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt:
+
2018-07-03 Antoine Quint <[email protected]>
[Web Animations] Make WPT test at timing-model/timelines/timelines.html pass reliably
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt (233518 => 233519)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt 2018-07-05 14:56:13 UTC (rev 233519)
@@ -1,6 +1,4 @@
-Harness Error (TIMEOUT), message = null
-
PASS Test exceptions when finishing non-running animation
PASS Test exceptions when finishing infinite animation
PASS Test finishing of animation
@@ -14,6 +12,6 @@
PASS Test finish() during aborted pause
PASS Test resetting of computed style
PASS Test finish() resolves finished promise synchronously
-TIMEOUT Test finish() resolves finished promise synchronously with an animation without a target Test timed out
-NOTRUN Test normally finished animation resolves finished promise synchronously with an animation without a target
+PASS Test finish() resolves finished promise synchronously with an animation without a target
+FAIL Test normally finished animation resolves finished promise synchronously with an animation without a target assert_true: Animation.finished should be resolved soon after Animation finishes normally expected true got false
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt (233518 => 233519)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt 2018-07-05 14:56:13 UTC (rev 233519)
@@ -1,9 +1,7 @@
-Harness Error (TIMEOUT), message = null
-
PASS The current time returns the hold time when set
-TIMEOUT The current time is unresolved when there is no associated timeline (and no hold time is set) Test timed out
+PASS The current time is unresolved when there is no associated timeline (and no hold time is set)
PASS The current time is unresolved when the start time is unresolved (and no hold time is set)
PASS The current time is calculated from the timeline time, start time and playback rate
-NOTRUN The current time does not progress if playback rate is 0
+PASS The current time does not progress if playback rate is 0
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt (233518 => 233519)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt 2018-07-05 14:56:13 UTC (rev 233519)
@@ -3,7 +3,7 @@
PASS Setting an unresolved start time an animation without an active timeline does not clear the current time
PASS Setting the start time clears the hold time
PASS Setting an unresolved start time sets the hold time
-FAIL Setting the start time resolves a pending ready promise assert_true: Ready promise callback called after setting startTime expected true got false
-FAIL Setting the start time resolves a pending pause task assert_true: Ready promise callback called after setting startTime expected true got false
+PASS Setting the start time resolves a pending ready promise
+PASS Setting the start time resolves a pending pause task
PASS Setting the start time updates the finished state
Modified: trunk/Source/WebCore/ChangeLog (233518 => 233519)
--- trunk/Source/WebCore/ChangeLog 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/Source/WebCore/ChangeLog 2018-07-05 14:56:13 UTC (rev 233519)
@@ -1,3 +1,16 @@
+2018-07-05 Antoine Quint <[email protected]>
+
+ [Web Animations] The ready promise should initially be resolved
+ https://bugs.webkit.org/show_bug.cgi?id=187341
+ <rdar://problem/41844711>
+
+ Reviewed by Dean Jackson.
+
+ The Web Animations spec mandates that the ready promise is initially resolved.
+
+ * animation/WebAnimation.cpp:
+ (WebCore::WebAnimation::WebAnimation):
+
2018-07-05 Sergio Villar Senin <[email protected]>
[WebVR] Fix VRDisplayEvent implementation
Modified: trunk/Source/WebCore/animation/WebAnimation.cpp (233518 => 233519)
--- trunk/Source/WebCore/animation/WebAnimation.cpp 2018-07-05 14:18:02 UTC (rev 233518)
+++ trunk/Source/WebCore/animation/WebAnimation.cpp 2018-07-05 14:56:13 UTC (rev 233519)
@@ -63,6 +63,7 @@
, m_readyPromise(makeUniqueRef<ReadyPromise>(*this, &WebAnimation::readyPromiseResolve))
, m_finishedPromise(makeUniqueRef<FinishedPromise>(*this, &WebAnimation::finishedPromiseResolve))
{
+ m_readyPromise->resolve(*this);
suspendIfNeeded();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
