Title: [233531] trunk/Tools
Revision
233531
Author
[email protected]
Date
2018-07-05 11:36:25 -0700 (Thu, 05 Jul 2018)

Log Message

[ews-build] Bindings-tests-EWS should output result in json
https://bugs.webkit.org/show_bug.cgi?id=187330

Reviewed by David Kilzer.

* BuildSlaveSupport/ews-build/steps.py:
(RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (233530 => 233531)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2018-07-05 18:18:22 UTC (rev 233530)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2018-07-05 18:36:25 UTC (rev 233531)
@@ -79,7 +79,9 @@
     description = ['bindings-tests running']
     descriptionDone = ['bindings-tests']
     flunkOnFailure = True
-    command = ['Tools/Scripts/run-bindings-tests']
+    jsonFileName = 'bindings_test_results.json'
+    logfiles = {'json': jsonFileName}
+    command = ['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(jsonFileName)]
 
 
 class RunWebKitPerlTests(shell.ShellCommand):

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (233530 => 233531)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2018-07-05 18:18:22 UTC (rev 233530)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2018-07-05 18:36:25 UTC (rev 233531)
@@ -231,6 +231,7 @@
 class TestRunBindingsTests(BuildStepMixinAdditions, unittest.TestCase):
     def setUp(self):
         self.longMessage = True
+        self.jsonFileName = 'bindings_test_results.json'
         return self.setUpBuildStep()
 
     def tearDown(self):
@@ -240,7 +241,8 @@
         self.setupStep(RunBindingsTests())
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=['Tools/Scripts/run-bindings-tests'],
+                        command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+                        logfiles={'json': self.jsonFileName},
                         )
             + 0,
         )
@@ -251,7 +253,8 @@
         self.setupStep(RunBindingsTests())
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=['Tools/Scripts/run-bindings-tests'],
+                        command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+                        logfiles={'json': self.jsonFileName},
                         )
             + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')
             + 2,

Modified: trunk/Tools/ChangeLog (233530 => 233531)


--- trunk/Tools/ChangeLog	2018-07-05 18:18:22 UTC (rev 233530)
+++ trunk/Tools/ChangeLog	2018-07-05 18:36:25 UTC (rev 233531)
@@ -1,5 +1,16 @@
 2018-07-05  Aakash Jain  <[email protected]>
 
+        [ews-build] Bindings-tests-EWS should output result in json
+        https://bugs.webkit.org/show_bug.cgi?id=187330
+
+        Reviewed by David Kilzer.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
+2018-07-05  Aakash Jain  <[email protected]>
+
         [ews-build] WebKitPy-Tests-EWS should output result in json
         https://bugs.webkit.org/show_bug.cgi?id=187331
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to