Title: [233548] trunk/Source/WebKit
- Revision
- 233548
- Author
- [email protected]
- Date
- 2018-07-05 16:17:40 -0700 (Thu, 05 Jul 2018)
Log Message
REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
https://bugs.webkit.org/show_bug.cgi?id=187367
<rdar://problem/41861346>
Reviewed by Timothy Hatcher.
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::computeElementLayout):
There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233547 => 233548)
--- trunk/Source/WebKit/ChangeLog 2018-07-05 23:12:04 UTC (rev 233547)
+++ trunk/Source/WebKit/ChangeLog 2018-07-05 23:17:40 UTC (rev 233548)
@@ -1,3 +1,15 @@
+2018-07-05 Brian Burg <[email protected]>
+
+ REGRESSION: ASSERT under WebAutomationSessionProxy::computeElementLayout when elementInViewClientCenterPoint returns nullopt
+ https://bugs.webkit.org/show_bug.cgi?id=187367
+ <rdar://problem/41861346>
+
+ Reviewed by Timothy Hatcher.
+
+ * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+ (WebKit::WebAutomationSessionProxy::computeElementLayout):
+ There's no reason to unwrap this optional, as the IPC argument type is std::optional<IntPoint>.
+
2018-07-05 Tim Horton <[email protected]>
Upstream hover gesture implementation
Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp (233547 => 233548)
--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp 2018-07-05 23:12:04 UTC (rev 233547)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp 2018-07-05 23:17:40 UTC (rev 233548)
@@ -617,7 +617,7 @@
}
}
- WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidComputeElementLayout(callbackID, resultElementBounds, resultInViewCenterPoint.value(), isObscured, String()), 0);
+ WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidComputeElementLayout(callbackID, resultElementBounds, resultInViewCenterPoint, isObscured, String()), 0);
}
void WebAutomationSessionProxy::selectOptionElement(uint64_t pageID, uint64_t frameID, String nodeHandle, uint64_t callbackID)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
