Title: [233553] trunk/Source/WebKit
- Revision
- 233553
- Author
- [email protected]
- Date
- 2018-07-05 17:40:22 -0700 (Thu, 05 Jul 2018)
Log Message
iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
https://bugs.webkit.org/show_bug.cgi?id=187363
<rdar://problem/41106306>
Patch by Olivia Barnett <[email protected]> on 2018-07-05
Reviewed by Tim Horton.
Added extra check to prevent keyboard scrolling when the select box is open.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _scrollOffsetForEvent:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233552 => 233553)
--- trunk/Source/WebKit/ChangeLog 2018-07-06 00:38:10 UTC (rev 233552)
+++ trunk/Source/WebKit/ChangeLog 2018-07-06 00:40:22 UTC (rev 233553)
@@ -1,3 +1,16 @@
+2018-07-05 Olivia Barnett <[email protected]>
+
+ iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
+ https://bugs.webkit.org/show_bug.cgi?id=187363
+ <rdar://problem/41106306>
+
+ Reviewed by Tim Horton.
+
+ Added extra check to prevent keyboard scrolling when the select box is open.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _scrollOffsetForEvent:]):
+
2018-07-05 Timothy Hatcher <[email protected]>
Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (233552 => 233553)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-07-06 00:38:10 UTC (rev 233552)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-07-06 00:40:22 UTC (rev 233553)
@@ -3655,6 +3655,9 @@
if (_page->editorState().isContentEditable)
return std::nullopt;
+
+ if (_assistedNodeInformation.elementType == InputType::Select)
+ return std::nullopt;
NSString *charactersIgnoringModifiers = event.charactersIgnoringModifiers;
if (!charactersIgnoringModifiers.length)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
