Title: [233572] trunk/Source/WebCore
- Revision
- 233572
- Author
- [email protected]
- Date
- 2018-07-06 00:48:51 -0700 (Fri, 06 Jul 2018)
Log Message
Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
https://bugs.webkit.org/show_bug.cgi?id=187317
Patch by Frederic Wang <[email protected]> on 2018-07-06
Reviewed by Ryosuke Niwa.
This function is called with a new custom element or the fallback HTMLUnknownElement element
so we rename it didCreateCustomOrFallbackElement.
No new tests, behavior unchanged.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
(WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.
* html/parser/HTMLTreeBuilder.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233571 => 233572)
--- trunk/Source/WebCore/ChangeLog 2018-07-06 07:37:50 UTC (rev 233571)
+++ trunk/Source/WebCore/ChangeLog 2018-07-06 07:48:51 UTC (rev 233572)
@@ -1,3 +1,22 @@
+2018-07-06 Frederic Wang <[email protected]>
+
+ Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
+ https://bugs.webkit.org/show_bug.cgi?id=187317
+
+ Reviewed by Ryosuke Niwa.
+
+ This function is called with a new custom element or the fallback HTMLUnknownElement element
+ so we rename it didCreateCustomOrFallbackElement.
+
+ No new tests, behavior unchanged.
+
+ * html/parser/HTMLDocumentParser.cpp:
+ (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
+ * html/parser/HTMLTreeBuilder.cpp:
+ (WebCore::HTMLTreeBuilder::didCreateCustomOrFallbackElement):
+ (WebCore::HTMLTreeBuilder::didCreateCustomOrCallbackElement): Deleted.
+ * html/parser/HTMLTreeBuilder.h:
+
2018-07-05 Ryosuke Niwa <[email protected]>
REGRESSION(r233496): macOS Sierra hits debug assertions in TrackListBase::suspend
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (233571 => 233572)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2018-07-06 07:37:50 UTC (rev 233571)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2018-07-06 07:48:51 UTC (rev 233572)
@@ -200,7 +200,7 @@
// https://html.spec.whatwg.org/#create-an-element-for-the-token
auto& elementInterface = constructionData->elementInterface.get();
auto newElement = elementInterface.constructElementWithFallback(*document(), constructionData->name);
- m_treeBuilder->didCreateCustomOrCallbackElement(WTFMove(newElement), *constructionData);
+ m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData);
return;
}
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (233571 => 233572)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2018-07-06 07:37:50 UTC (rev 233571)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp 2018-07-06 07:48:51 UTC (rev 233572)
@@ -873,7 +873,7 @@
m_customElementToConstruct = m_tree.insertHTMLElementOrFindCustomElementInterface(WTFMove(token));
}
-void HTMLTreeBuilder::didCreateCustomOrCallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
+void HTMLTreeBuilder::didCreateCustomOrFallbackElement(Ref<Element>&& element, CustomElementConstructionData& data)
{
m_tree.insertCustomElement(WTFMove(element), data.name, WTFMove(data.attributes));
}
Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h (233571 => 233572)
--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h 2018-07-06 07:37:50 UTC (rev 233571)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h 2018-07-06 07:48:51 UTC (rev 233572)
@@ -66,7 +66,7 @@
RefPtr<ScriptElement> takeScriptToProcess(TextPosition& scriptStartPosition);
std::unique_ptr<CustomElementConstructionData> takeCustomElementConstructionData() { return WTFMove(m_customElementToConstruct); }
- void didCreateCustomOrCallbackElement(Ref<Element>&&, CustomElementConstructionData&);
+ void didCreateCustomOrFallbackElement(Ref<Element>&&, CustomElementConstructionData&);
// Done, close any open tags, etc.
void finished();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
