Title: [233575] trunk/Source/WebCore
- Revision
- 233575
- Author
- [email protected]
- Date
- 2018-07-06 03:38:46 -0700 (Fri, 06 Jul 2018)
Log Message
[GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
https://bugs.webkit.org/show_bug.cgi?id=187381
Patch by Carlos Garcia Campos <[email protected]> on 2018-07-06
Reviewed by Yusuke Suzuki.
This is because the static variable for proxy settings was replaced by a NeverDestroyed, but the function is not
returning a reference, but a copy. This is causing several unit tests to fail.
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::proxySettings):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233574 => 233575)
--- trunk/Source/WebCore/ChangeLog 2018-07-06 10:10:50 UTC (rev 233574)
+++ trunk/Source/WebCore/ChangeLog 2018-07-06 10:38:46 UTC (rev 233575)
@@ -1,3 +1,16 @@
+2018-07-06 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
+ https://bugs.webkit.org/show_bug.cgi?id=187381
+
+ Reviewed by Yusuke Suzuki.
+
+ This is because the static variable for proxy settings was replaced by a NeverDestroyed, but the function is not
+ returning a reference, but a copy. This is causing several unit tests to fail.
+
+ * platform/network/soup/SoupNetworkSession.cpp:
+ (WebCore::proxySettings):
+
2018-07-06 Frederic Wang <[email protected]>
[Crash] Illegal use of uninitialized std::optional value in WebCore::AnimationBase::updateStateMachine
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (233574 => 233575)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2018-07-06 10:10:50 UTC (rev 233574)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2018-07-06 10:38:46 UTC (rev 233575)
@@ -53,7 +53,7 @@
return storage.get();
}
-static SoupNetworkProxySettings proxySettings()
+static SoupNetworkProxySettings& proxySettings()
{
static NeverDestroyed<SoupNetworkProxySettings> settings;
return settings.get();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
