Diff
Modified: trunk/LayoutTests/ChangeLog (233577 => 233578)
--- trunk/LayoutTests/ChangeLog 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/ChangeLog 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,3 +1,44 @@
+2018-07-06 Daniel Bates <[email protected]>
+
+ Remove Strong Confirmation Password button
+ https://bugs.webkit.org/show_bug.cgi?id=187306
+ <rdar://problem/41795185>
+
+ Reviewed by Sam Weinig.
+
+ Remove support for the Strong Confirmation Password button because we never made use of it.
+
+ * accessibility/ios-simulator/strong-password-field-expected.txt:
+ * accessibility/ios-simulator/strong-password-field.html:
+ * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html:
+ * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html:
+ * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html:
+ * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html:
+ * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html:
+ * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:
+ * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html:
+ * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html:
+ * fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html:
+ * fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html:
+ * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html: Removed.
+ * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html: Removed.
+ * fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html: Removed.
+ * fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html: Removed.
+ * fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
+ * fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
+ * fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
+ * fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
+ * fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html: Removed.
+ * fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
+ * fast/forms/auto-fill-button/last-auto-fill-button-type.html:
+ * platform/gtk/TestExpectations:
+ * platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
+ * platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
+ * platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
+ * platform/win/TestExpectations:
+ * platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
+ * platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
+
2018-07-05 Carlos Garcia Campos <[email protected]>
Unreviewed GTK gardening. Remove platform expectations for imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
Modified: trunk/LayoutTests/accessibility/ios-simulator/strong-password-field-expected.txt (233577 => 233578)
--- trunk/LayoutTests/accessibility/ios-simulator/strong-password-field-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/accessibility/ios-simulator/strong-password-field-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -6,10 +6,8 @@
PASS axPw1.boolAttributeValue('AXIsStrongPasswordField') is false
PASS axPw2.boolAttributeValue('AXIsStrongPasswordField') is true
-PASS axPw3.boolAttributeValue('AXIsStrongPasswordField') is true
PASS axPw1.stringValue is 'AXValue: ••••••••'
PASS axPw2.stringValue is 'AXValue: strong password'
-PASS axPw3.stringValue is 'AXValue: strong confirmation password'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/ios-simulator/strong-password-field.html (233577 => 233578)
--- trunk/LayoutTests/accessibility/ios-simulator/strong-password-field.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/accessibility/ios-simulator/strong-password-field.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -9,7 +9,6 @@
<div id="container">
<input id="pw1" type="password" value="password">
<input id="pw2" type="password" value="strong password">
-<input id="pw3" type="password" value="strong confirmation password">
</div>
<p id="description"></p>
@@ -21,28 +20,21 @@
var pw1 = document.getElementById("pw1");
var pw2 = document.getElementById("pw2");
- var pw3 = document.getElementById("pw3");
if (window.internals) {
window.internals.setAutofilled(pw2, true);
- window.internals.setShowAutoFillButton(pw2, "StrongConfirmationPassword");
-
- window.internals.setAutofilled(pw3, true);
- window.internals.setShowAutoFillButton(pw3, "StrongPassword");
+ window.internals.setShowAutoFillButton(pw2, "StrongPassword");
}
if (window.accessibilityController) {
var axPw1 = accessibilityController.accessibleElementById("pw1");
var axPw2 = accessibilityController.accessibleElementById("pw2");
- var axPw3 = accessibilityController.accessibleElementById("pw3");
shouldBeFalse("axPw1.boolAttributeValue('AXIsStrongPasswordField')");
shouldBeTrue("axPw2.boolAttributeValue('AXIsStrongPasswordField')");
- shouldBeTrue("axPw3.boolAttributeValue('AXIsStrongPasswordField')");
shouldBe("axPw1.stringValue", "'AXValue: ••••••••'");
shouldBe("axPw2.stringValue", "'AXValue: strong password'");
- shouldBe("axPw3.stringValue", "'AXValue: strong confirmation password'");
}
</script>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -16,8 +16,7 @@
</script>
</head>
<body>
-<p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
+<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -19,8 +19,7 @@
</script>
</head>
<body>
-<p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
+<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -16,8 +16,7 @@
</script>
</head>
<body>
-<p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
+<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -19,8 +19,7 @@
</script>
</head>
<body>
-<p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
+<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,10 +1,9 @@
<!DOCTYPE html>
<html>
<body>
-<p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
+<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
<form>
<input type="password" value="Cupertino">
-<input type="password" value="Cupertino">
</form>
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -17,10 +17,9 @@
</script>
</head>
<body>
-<p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
+<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
<form>
<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</form>
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,8 +1,7 @@
<!DOCTYPE html>
<html>
<body>
-<p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
+<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
<input type="password" value="">
-<input type="password" value="">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -19,8 +19,7 @@
</script>
</head>
<body>
-<p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
+<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
-<input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,8 +1,7 @@
<!DOCTYPE html>
<html>
<body>
-<p>This tests that a text field decorated as a Strong Password or Strong Confirmation Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
+<p>This tests that a text field decorated as a Strong Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
<input type="text" value="Cupertino">
-<input type="text" value="Cupertino">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -19,8 +19,7 @@
</script>
</head>
<body>
-<p>This tests that a text field decorated as a Strong Password or Strong Confirmation Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
+<p>This tests that a text field decorated as a Strong Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword">
-<input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword">
</body>
</html>
Deleted: trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This tests that a disabled field with the Strong Password AutoFill buttons renders identical to a disabled field with the Strong Confirmation AutoFill button. It can only be tested in the test tool.</p>
-<input type="password" placeholder="disabled" disabled>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." disabled>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." style="width:300px" disabled>
-<script>
-if (window.internals) {
- var inputElements = document.getElementsByTagName("input");
- for (let inputElement of inputElements) {
- internals.setAutofilled(inputElement, true);
- internals.setShowAutoFillButton(inputElement, "StrongConfirmationPassword");
- }
-}
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This tests that a disabled field with the Strong Password AutoFill buttons renders identical to a disabled field with the Strong Confirmation AutoFill button. It can only be tested in the test tool.</p>
-<input type="password" placeholder="disabled" disabled>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." disabled>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." style="width:300px" disabled>
-<script>
-if (window.internals) {
- var inputElements = document.getElementsByTagName("input");
- for (let inputElement of inputElements) {
- internals.setAutofilled(inputElement, true);
- internals.setShowAutoFillButton(inputElement, "StrongPassword");
- }
-}
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This tests that a readonly field with the Strong Password AutoFill buttons renders identical to a disabled field with the Strong Confirmation AutoFill button. It can only be tested in the test tool.</p>
-<input type="password" placeholder="read only" readonly>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." readonly>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." style="width:300px" readonly>
-<script>
-if (window.internals) {
- var inputElements = document.getElementsByTagName("input");
- for (let inputElement of inputElements) {
- internals.setAutofilled(inputElement, true);
- internals.setShowAutoFillButton(inputElement, "StrongConfirmationPassword");
- }
-}
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This tests that a readonly field with the Strong Password AutoFill buttons renders identical to a disabled field with the Strong Confirmation AutoFill button. It can only be tested in the test tool.</p>
-<input type="password" placeholder="read only" readonly>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." readonly>
-<br>
-<input type="password" value="A quick brown fox jumped over the lazy dog." style="width:300px" readonly>
-<script>
-if (window.internals) {
- var inputElements = document.getElementsByTagName("input");
- for (let inputElement of inputElements) {
- internals.setAutofilled(inputElement, true);
- internals.setShowAutoFillButton(inputElement, "StrongPassword");
- }
-}
-</script>
-</body>
-</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,8 +1,7 @@
<!DOCTYPE html>
<html>
<body>
-<p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render in a disabled field. It can only be tested in the test tool.</p>
+<p>This tests that the Strong Password button does not render in a disabled field. It can only be tested in the test tool.</p>
<input type="password" placeholder="disabled" disabled>
-<input type="password" placeholder="disabled" disabled>
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -4,8 +4,7 @@
<script src=""
</head>
<body>
-<p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render in a disabled field. It can only be tested in the test tool.</p>
+<p>This tests that the Strong Password button does not render in a disabled field. It can only be tested in the test tool.</p>
<input type="password" placeholder="disabled" disabled data-auto-fill-button-type="StrongPassword">
-<input type="password" placeholder="disabled" disabled data-auto-fill-button-type="StrongConfirmationPassword">
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,8 +1,7 @@
<!DOCTYPE html>
<html>
<body>
-<p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render read only field. It can only be tested in the test tool.</p>
+<p>This tests that the Strong Password button does not render read only field. It can only be tested in the test tool.</p>
<input type="password" placeholder="read only" readonly>
-<input type="password" placeholder="read only" readonly>
</body>
</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -4,8 +4,7 @@
<script src=""
</head>
<body>
-<p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render read only field. It can only be tested in the test tool.</p>
+<p>This tests that the Strong Password button does not render read only field. It can only be tested in the test tool.</p>
<input type="password" placeholder="read only" readonly data-auto-fill-button-type="StrongPassword">
-<input type="password" placeholder="read only" readonly data-auto-fill-button-type="StrongConfirmationPassword">
</body>
</html>
Deleted: trunk/LayoutTests/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,28 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the test tool.</p>
-<div id="container">
- <input type="text" value="A quick brown fox jumped over the lazy dog.">
- <input type="password" value="A quick brown fox jumped over the lazy dog.">
- <input type="password" value="A quick brown fox jumped over the lazy dog." style="width:300px">
- <input type="password" value="A quick brown fox jumped over the lazy dog." style="width:20px">
- <input type="password" value="A quick brown fox jumped over the lazy dog." style="height:100px">
- <input type="password" value="A quick brown fox jumped over the lazy dog." style="width:20px; height:100px">
-</div>
-<script>
-if (window.internals) {
- var inputs = document.querySelectorAll("input");
- for (var i = 0; i < inputs.length; ++i) {
- window.internals.setAutofilled(inputs[i], true);
- window.internals.setShowAutoFillButton(inputs[i], "StrongConfirmationPassword");
- }
-
- var dynamicInput = document.createElement("input");
- window.internals.setAutofilled(dynamicInput, true);
- window.internals.setShowAutoFillButton(dynamicInput, "StrongConfirmationPassword");
- document.querySelector("#container").appendChild(dynamicInput);
-}
-</script>
-</body>
-</html>
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -13,12 +13,12 @@
internals.setShowAutoFillButton(inputElement, 'StrongPassword')
PASS internals.autoFillButtonType(inputElement) is "StrongPassword"
PASS internals.lastAutoFillButtonType(inputElement) is "Contacts"
-internals.setShowAutoFillButton(inputElement, 'StrongConfirmationPassword')
-PASS internals.autoFillButtonType(inputElement) is "StrongConfirmationPassword"
+internals.setShowAutoFillButton(inputElement, 'Credentials')
+PASS internals.autoFillButtonType(inputElement) is "Credentials"
PASS internals.lastAutoFillButtonType(inputElement) is "StrongPassword"
internals.setShowAutoFillButton(inputElement, 'None')
PASS internals.autoFillButtonType(inputElement) is "None"
-PASS internals.lastAutoFillButtonType(inputElement) is "StrongConfirmationPassword"
+PASS internals.lastAutoFillButtonType(inputElement) is "Credentials"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type.html (233577 => 233578)
--- trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type.html 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type.html 2018-07-06 16:29:40 UTC (rev 233578)
@@ -22,12 +22,12 @@
evalAndLog("internals.setShowAutoFillButton(inputElement, 'StrongPassword')");
shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "StrongPassword");
shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "Contacts");
- evalAndLog("internals.setShowAutoFillButton(inputElement, 'StrongConfirmationPassword')");
- shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "StrongConfirmationPassword");
+ evalAndLog("internals.setShowAutoFillButton(inputElement, 'Credentials')");
+ shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "Credentials");
shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "StrongPassword");
evalAndLog("internals.setShowAutoFillButton(inputElement, 'None')");
shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "None");
- shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "StrongConfirmationPassword");
+ shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "Credentials");
}
</script>
</body>
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (233577 => 233578)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-07-06 16:29:40 UTC (rev 233578)
@@ -3350,7 +3350,6 @@
webkit.org/b/180805 inspector/canvas/requestContent-bitmaprenderer.html [ Failure ]
webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html [ Missing Failure ]
-webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html [ Missing Failure ]
webkit.org/b/182050 http/wpt/fetch/response-opaque-clone.html [ Pass Crash ]
Deleted: trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (233577 => 233578)
--- trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,46 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x132
- RenderBlock {HTML} at (0,0) size 800x132
- RenderBody {BODY} at (8,16) size 784x108
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 771x35
- text run at (0,0) width 771: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the"
- text run at (0,18) width 53: "test tool."
- RenderBlock {DIV} at (0,52) size 784x56
- RenderTextControl {INPUT} at (2,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (3,3) size 185x18
- RenderBlock {DIV} at (0,0) size 185x18
- RenderBlock {DIV} at (185,9) size 0x0
- RenderText {#text} at (195,5) size 4x17
- text run at (195,5) width 4: " "
- RenderTextControl {INPUT} at (201,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (3,3) size 185x18
- RenderBlock {DIV} at (0,0) size 185x18
- RenderBlock {DIV} at (185,9) size 0x0
- RenderText {#text} at (394,5) size 4x17
- text run at (394,5) width 4: " "
- RenderTextControl {INPUT} at (398,2) size 306x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (3,3) size 300x18
- RenderBlock {DIV} at (0,0) size 300x18
- RenderBlock {DIV} at (300,9) size 0x0
- RenderText {#text} at (704,5) size 4x17
- text run at (704,5) width 4: " "
- RenderTextControl {INPUT} at (2,30) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (3,3) size 185x18
- RenderBlock {DIV} at (0,0) size 185x18
- RenderBlock {DIV} at (185,9) size 0x0
-layer at (13,73) size 185x18 scrollWidth 312
- RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099]
- RenderText {#text} at (0,0) size 312x17
- text run at (0,0) width 312: "A quick brown fox jumped over the lazy dog."
-layer at (212,73) size 185x18 scrollWidth 258
- RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099]
- RenderText {#text} at (0,0) size 258x17
- text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}"
-layer at (409,73) size 300x18
- RenderBlock {DIV} at (0,0) size 300x18 [color=#00000099]
- RenderText {#text} at (0,0) size 258x17
- text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}"
-layer at (13,101) size 185x18
- RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099]
Deleted: trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (233577 => 233578)
--- trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,87 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x211
- RenderBlock {HTML} at (0,0) size 800x211
- RenderBody {BODY} at (8,16) size 784x187
- RenderBlock {P} at (0,0) size 784x40
- RenderText {#text} at (0,0) size 766x39
- text run at (0,0) width 766: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in"
- text run at (0,20) width 79: "the test tool."
- RenderBlock {DIV} at (0,56) size 784x131
- RenderTextControl {INPUT} at (2,3) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (157,0) size 4x19
- text run at (157,0) width 4: " "
- RenderTextControl {INPUT} at (163,3) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (318,0) size 4x19
- text run at (318,0) width 4: " "
- RenderTextControl {INPUT} at (322,3) size 313x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (635,0) size 4x19
- text run at (635,0) width 4: " "
- RenderTextControl {INPUT} at (639,3) size 33x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (0,0) size 0x0
- RenderTextControl {INPUT} at (2,24) size 153x108 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (157,65) size 4x19
- text run at (157,65) width 4: " "
- RenderTextControl {INPUT} at (161,24) size 33x108 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
- RenderText {#text} at (194,65) size 4x19
- text run at (194,65) width 4: " "
- RenderTextControl {INPUT} at (200,68) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
-layer at (17,78) size 140x12
- RenderFlexibleBox {DIV} at (6,3) size 141x13
- RenderBlock {DIV} at (140,6) size 0x0
-layer at (17,78) size 140x12
- RenderBlock {DIV} at (0,0) size 140x12
-layer at (178,78) size 140x12
- RenderFlexibleBox {DIV} at (6,3) size 141x13
- RenderBlock {DIV} at (140,6) size 0x0
-layer at (178,78) size 140x12
- RenderBlock {DIV} at (0,0) size 140x12
-layer at (337,78) size 300x12
- RenderFlexibleBox {DIV} at (6,3) size 301x13
- RenderBlock {DIV} at (300,6) size 0x0
-layer at (337,78) size 300x12
- RenderBlock {DIV} at (0,0) size 300x12
-layer at (654,78) size 20x12
- RenderFlexibleBox {DIV} at (6,3) size 21x13
- RenderBlock {DIV} at (20,6) size 0x0
-layer at (654,78) size 20x12
- RenderBlock {DIV} at (0,0) size 20x12
-layer at (17,99) size 140x100
- RenderFlexibleBox {DIV} at (6,3) size 141x101
- RenderBlock {DIV} at (140,50) size 0x0
-layer at (17,143) size 140x12
- RenderBlock {DIV} at (0,44) size 140x12
-layer at (176,99) size 20x100
- RenderFlexibleBox {DIV} at (6,3) size 21x101
- RenderBlock {DIV} at (20,50) size 0x0
-layer at (176,143) size 20x12
- RenderBlock {DIV} at (0,44) size 20x12
-layer at (215,143) size 140x12
- RenderFlexibleBox {DIV} at (6,3) size 141x13
- RenderBlock {DIV} at (140,6) size 0x0
-layer at (215,143) size 140x12
- RenderBlock {DIV} at (0,0) size 140x12
-layer at (17,78) size 140x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 140x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (178,78) size 140x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 140x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (337,78) size 284x12 backgroundClip at (337,78) size 283x12 clip at (337,78) size 283x12
- RenderBlock {DIV} at (0,0) size 284x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (654,78) size 20x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 20x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (17,143) size 140x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 140x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (176,143) size 20x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 20x12 [color=#00000099]
- RenderText {#text} at (0,0) size 284x12
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
Deleted: trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (233577 => 233578)
--- trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,87 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x205
- RenderBlock {HTML} at (0,0) size 800x205
- RenderBody {BODY} at (8,16) size 784x181
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 764x36
- text run at (0,0) width 764: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in"
- text run at (0,18) width 79: "the test tool."
- RenderBlock {DIV} at (0,52) size 784x129
- RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (162,1) size 4x18
- text run at (162,1) width 4: " "
- RenderTextControl {INPUT} at (168,2) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (328,1) size 4x18
- text run at (328,1) width 4: " "
- RenderTextControl {INPUT} at (332,2) size 306x19 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (638,1) size 4x18
- text run at (638,1) width 4: " "
- RenderTextControl {INPUT} at (642,2) size 26x19 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (0,0) size 0x0
- RenderTextControl {INPUT} at (2,23) size 158x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (162,65) size 4x18
- text run at (162,65) width 4: " "
- RenderTextControl {INPUT} at (166,23) size 26x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderText {#text} at (192,65) size 4x18
- text run at (192,65) width 4: " "
- RenderTextControl {INPUT} at (198,66) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
-layer at (13,73) size 152x13
- RenderFlexibleBox {DIV} at (3,3) size 152x13
- RenderBlock {DIV} at (152,6) size 0x0
-layer at (13,73) size 152x13
- RenderBlock {DIV} at (0,0) size 152x13
-layer at (179,73) size 152x13
- RenderFlexibleBox {DIV} at (3,3) size 152x13
- RenderBlock {DIV} at (152,6) size 0x0
-layer at (179,73) size 152x13
- RenderBlock {DIV} at (0,0) size 152x13
-layer at (343,73) size 300x13
- RenderFlexibleBox {DIV} at (3,3) size 300x13
- RenderBlock {DIV} at (300,6) size 0x0
-layer at (343,73) size 300x13
- RenderBlock {DIV} at (0,0) size 300x13
-layer at (653,73) size 20x13
- RenderFlexibleBox {DIV} at (3,3) size 20x13
- RenderBlock {DIV} at (20,6) size 0x0
-layer at (653,73) size 20x13
- RenderBlock {DIV} at (0,0) size 20x13
-layer at (13,94) size 152x100
- RenderFlexibleBox {DIV} at (3,3) size 152x100
- RenderBlock {DIV} at (152,50) size 0x0
-layer at (13,138) size 152x13
- RenderBlock {DIV} at (0,43) size 152x14
-layer at (177,94) size 20x100
- RenderFlexibleBox {DIV} at (3,3) size 20x100
- RenderBlock {DIV} at (20,50) size 0x0
-layer at (177,138) size 20x13
- RenderBlock {DIV} at (0,43) size 20x14
-layer at (209,137) size 152x13
- RenderFlexibleBox {DIV} at (3,3) size 152x13
- RenderBlock {DIV} at (152,6) size 0x0
-layer at (209,137) size 152x13
- RenderBlock {DIV} at (0,0) size 152x13
-layer at (13,73) size 152x13 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 152x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (179,73) size 152x13 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 152x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (343,73) size 284x13
- RenderBlock {DIV} at (0,0) size 284x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (653,73) size 20x13 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 20x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (13,138) size 152x13 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 152x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
-layer at (177,138) size 20x13 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 20x13 [color=#00000099]
- RenderText {#text} at (0,0) size 284x13
- text run at (0,0) width 284: "A quick brown fox jumped over the lazy dog."
Modified: trunk/LayoutTests/platform/win/TestExpectations (233577 => 233578)
--- trunk/LayoutTests/platform/win/TestExpectations 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/win/TestExpectations 2018-07-06 16:29:40 UTC (rev 233578)
@@ -3944,7 +3944,6 @@
webkit.org/b/181501 accessibility/table-header-calculation-for-header-rows.html [ Failure ]
webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html [ Failure ]
-webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html [ Failure ]
webkit.org/b/181854 svg/filters/feDiffuseLighting-bottomRightPixel.html [ ImageOnlyFailure ]
Deleted: trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (233577 => 233578)
--- trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,46 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x101
- RenderBlock {HTML} at (0,0) size 800x101
- RenderBody {BODY} at (8,16) size 784x77
- RenderBlock {P} at (0,0) size 784x36
- RenderText {#text} at (0,0) size 771x36
- text run at (0,0) width 771: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the"
- text run at (0,18) width 53: "test tool."
- RenderBlock {DIV} at (0,52) size 784x25
- RenderTextControl {INPUT} at (2,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 145x15
- RenderBlock {DIV} at (0,0) size 145x15
- RenderBlock {DIV} at (145,7) size 0x0
- RenderText {#text} at (153,3) size 4x18
- text run at (153,3) width 4: " "
- RenderTextControl {INPUT} at (159,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 145x15
- RenderBlock {DIV} at (0,0) size 145x15
- RenderBlock {DIV} at (145,7) size 0x0
- RenderText {#text} at (310,3) size 4x18
- text run at (310,3) width 4: " "
- RenderTextControl {INPUT} at (314,2) size 304x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 300x15
- RenderBlock {DIV} at (0,0) size 300x15
- RenderBlock {DIV} at (300,7) size 0x0
- RenderText {#text} at (618,3) size 4x18
- text run at (618,3) width 4: " "
- RenderTextControl {INPUT} at (624,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 145x15
- RenderBlock {DIV} at (0,0) size 145x15
- RenderBlock {DIV} at (145,7) size 0x0
-layer at (12,73) size 145x15 scrollWidth 250
- RenderBlock {DIV} at (0,0) size 145x15 [color=#00000099]
- RenderText {#text} at (0,0) size 250x15
- text run at (0,0) width 250: "A quick brown fox jumped over the lazy dog."
-layer at (169,73) size 145x15 scrollWidth 215
- RenderBlock {DIV} at (0,0) size 145x15 [color=#00000099]
- RenderText {#text} at (0,0) size 215x15
- text run at (0,0) width 215: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}"
-layer at (324,73) size 300x15
- RenderBlock {DIV} at (0,0) size 300x15 [color=#00000099]
- RenderText {#text} at (0,0) size 215x15
- text run at (0,0) width 215: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}"
-layer at (634,73) size 145x15
- RenderBlock {DIV} at (0,0) size 145x15 [color=#00000099]
Deleted: trunk/LayoutTests/platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (233577 => 233578)
--- trunk/LayoutTests/platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/LayoutTests/platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,46 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x132
- RenderBlock {HTML} at (0,0) size 800x132
- RenderBody {BODY} at (8,16) size 784x108
- RenderBlock {P} at (0,0) size 784x40
- RenderText {#text} at (0,0) size 757x39
- text run at (0,0) width 757: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the test"
- text run at (0,20) width 27: "tool."
- RenderBlock {DIV} at (0,56) size 784x52
- RenderTextControl {INPUT} at (2,2) size 168x22 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 164x16
- RenderBlock {DIV} at (0,0) size 164x16
- RenderBlock {DIV} at (164,8) size 0x0
- RenderText {#text} at (172,2) size 4x19
- text run at (172,2) width 4: " "
- RenderTextControl {INPUT} at (178,2) size 168x22 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 164x16
- RenderBlock {DIV} at (0,0) size 164x16
- RenderBlock {DIV} at (164,8) size 0x0
- RenderText {#text} at (348,2) size 4x19
- text run at (348,2) width 4: " "
- RenderTextControl {INPUT} at (352,2) size 304x22 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 300x16
- RenderBlock {DIV} at (0,0) size 300x16
- RenderBlock {DIV} at (300,8) size 0x0
- RenderText {#text} at (656,2) size 4x19
- text run at (656,2) width 4: " "
- RenderTextControl {INPUT} at (2,28) size 168x22 [bgcolor=#FAFFBD] [border: (2px inset #000000)]
- RenderFlexibleBox {DIV} at (2,3) size 164x16
- RenderBlock {DIV} at (0,0) size 164x16
- RenderBlock {DIV} at (164,8) size 0x0
-layer at (12,77) size 164x16 scrollWidth 344
- RenderBlock {DIV} at (0,0) size 164x16 [color=#00000099]
- RenderText {#text} at (0,0) size 344x16
- text run at (0,0) width 344: "A quick brown fox jumped over the lazy dog."
-layer at (188,77) size 164x16 scrollWidth 344
- RenderBlock {DIV} at (0,0) size 164x16 [color=#00000099]
- RenderText {#text} at (0,0) size 344x16
- text run at (0,0) width 344: "A quick brown fox jumped over the lazy dog."
-layer at (362,77) size 300x16 scrollWidth 344
- RenderBlock {DIV} at (0,0) size 300x16 [color=#00000099]
- RenderText {#text} at (0,0) size 344x16
- text run at (0,0) width 344: "A quick brown fox jumped over the lazy dog."
-layer at (12,103) size 164x16
- RenderBlock {DIV} at (0,0) size 164x16 [color=#00000099]
Modified: trunk/Source/WebCore/ChangeLog (233577 => 233578)
--- trunk/Source/WebCore/ChangeLog 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/ChangeLog 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,3 +1,37 @@
+2018-07-06 Daniel Bates <[email protected]>
+
+ Remove Strong Confirmation Password button
+ https://bugs.webkit.org/show_bug.cgi?id=187306
+ <rdar://problem/41795185>
+
+ Reviewed by Sam Weinig.
+
+ Remove support for the Strong Confirmation Password button because we never made use of it.
+
+ * English.lproj/Localizable.strings:
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper _accessibilityIsStrongPasswordField]):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+ * html/HTMLInputElement.h:
+ (WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const):
+ * html/HTMLTextFormControlElement.h:
+ * html/TextFieldInputType.cpp:
+ (WebCore::autoFillButtonTypeToAccessibilityLabel):
+ (WebCore::autoFillButtonTypeToAutoFillButtonText):
+ (WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
+ (WebCore::isAutoFillButtonTypeChanged):
+ * platform/LocalizedStrings.cpp:
+ (WebCore::AXAutoFillStrongConfirmationPasswordLabel): Deleted.
+ * platform/LocalizedStrings.h:
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::layout):
+ * testing/Internals.cpp:
+ (WebCore::toAutoFillButtonType):
+ (WebCore::toInternalsAutoFillButtonType):
+ * testing/Internals.h:
+ * testing/Internals.idl:
+
2018-07-06 Carlos Garcia Campos <[email protected]>
[GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (233577 => 233578)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1216,9 +1216,6 @@
/* Label for the strong password auto fill button inside a text field. */
"strong password auto fill" = "strong password auto fill";
-/* Label for the strong password confirmation auto fill button inside a text field. */
-"strong password confirmation auto fill" = "strong password confirmation auto fill";
-
/* The suboptimal value description for a meter element. */
"suboptimal value" = "suboptimal value";
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (233577 => 233578)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1092,8 +1092,7 @@
if (!m_object->isPasswordField())
return NO;
- AutoFillButtonType type = m_object->valueAutofillButtonType();
- return type == AutoFillButtonType::StrongConfirmationPassword || type == AutoFillButtonType::StrongPassword;
+ return m_object->valueAutofillButtonType() == AutoFillButtonType::StrongPassword;
}
- (CGFloat)_accessibilityMinValue
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (233577 => 233578)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2018-07-06 16:29:40 UTC (rev 233578)
@@ -3109,8 +3109,6 @@
return @"credentials";
case AutoFillButtonType::Contacts:
return @"contacts";
- case AutoFillButtonType::StrongConfirmationPassword:
- return @"strong confirmation password";
case AutoFillButtonType::StrongPassword:
return @"strong password";
}
Modified: trunk/Source/WebCore/html/HTMLInputElement.h (233577 => 233578)
--- trunk/Source/WebCore/html/HTMLInputElement.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/html/HTMLInputElement.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -242,7 +242,7 @@
AutoFillButtonType autoFillButtonType() const { return static_cast<AutoFillButtonType>(m_autoFillButtonType); }
WEBCORE_EXPORT void setShowAutoFillButton(AutoFillButtonType);
- bool hasAutoFillStrongPasswordButton() const { return autoFillButtonType() == AutoFillButtonType::StrongPassword || autoFillButtonType() == AutoFillButtonType::StrongConfirmationPassword; }
+ bool hasAutoFillStrongPasswordButton() const { return autoFillButtonType() == AutoFillButtonType::StrongPassword; }
bool isAutoFillAvailable() const { return m_isAutoFillAvailable; }
void setAutoFillAvailable(bool autoFillAvailable) { m_isAutoFillAvailable = autoFillAvailable; }
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.h (233577 => 233578)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -33,7 +33,7 @@
class TextControlInnerTextElement;
class VisiblePosition;
-enum class AutoFillButtonType : uint8_t { None, Credentials, Contacts, StrongConfirmationPassword, StrongPassword };
+enum class AutoFillButtonType : uint8_t { None, Credentials, Contacts, StrongPassword };
enum TextFieldSelectionDirection { SelectionHasNoDirection, SelectionHasForwardDirection, SelectionHasBackwardDirection };
enum TextFieldEventBehavior { DispatchNoEvent, DispatchChangeEvent, DispatchInputAndChangeEvent };
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (233577 => 233578)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2018-07-06 16:29:40 UTC (rev 233578)
@@ -450,8 +450,6 @@
return AXAutoFillContactsLabel();
case AutoFillButtonType::Credentials:
return AXAutoFillCredentialsLabel();
- case AutoFillButtonType::StrongConfirmationPassword:
- return AXAutoFillStrongConfirmationPasswordLabel();
case AutoFillButtonType::StrongPassword:
return AXAutoFillStrongPasswordLabel();
case AutoFillButtonType::None:
@@ -467,7 +465,6 @@
switch (autoFillButtonType) {
case AutoFillButtonType::Contacts:
case AutoFillButtonType::Credentials:
- case AutoFillButtonType::StrongConfirmationPassword:
return emptyString();
case AutoFillButtonType::StrongPassword:
return autoFillStrongPasswordLabel();
@@ -486,8 +483,6 @@
return { "-webkit-contacts-auto-fill-button", AtomicString::ConstructFromLiteral };
case AutoFillButtonType::Credentials:
return { "-webkit-credentials-auto-fill-button", AtomicString::ConstructFromLiteral };
- case AutoFillButtonType::StrongConfirmationPassword:
- return { "-webkit-strong-confirmation-password-auto-fill-button", AtomicString::ConstructFromLiteral };
case AutoFillButtonType::StrongPassword:
return { "-webkit-strong-password-auto-fill-button", AtomicString::ConstructFromLiteral };
case AutoFillButtonType::None:
@@ -504,8 +499,6 @@
return true;
if (attribute == "-webkit-credentials-auto-fill-button" && autoFillButtonType != AutoFillButtonType::Credentials)
return true;
- if (attribute == "-webkit-strong-confirmation-password-auto-fill-button" && autoFillButtonType != AutoFillButtonType::StrongConfirmationPassword)
- return true;
if (attribute == "-webkit-strong-password-auto-fill-button" && autoFillButtonType != AutoFillButtonType::StrongPassword)
return true;
return false;
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (233577 => 233578)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2018-07-06 16:29:40 UTC (rev 233578)
@@ -630,11 +630,6 @@
return WEB_UI_STRING("strong password auto fill", "Label for the strong password auto fill button inside a text field.");
}
-String AXAutoFillStrongConfirmationPasswordLabel()
-{
- return WEB_UI_STRING("strong password confirmation auto fill", "Label for the strong password confirmation auto fill button inside a text field.");
-}
-
String autoFillStrongPasswordLabel()
{
return WEB_UI_STRING("Strong Password", "Label for strong password.");
Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (233577 => 233578)
--- trunk/Source/WebCore/platform/LocalizedStrings.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -216,7 +216,6 @@
String AXAutoFillCredentialsLabel();
String AXAutoFillContactsLabel();
String AXAutoFillStrongPasswordLabel();
- String AXAutoFillStrongConfirmationPasswordLabel();
String autoFillStrongPasswordLabel();
String missingPluginText();
Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (233577 => 233578)
--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2018-07-06 16:29:40 UTC (rev 233578)
@@ -94,8 +94,7 @@
// - Shrink the heights of the inner elements if the input height is smaller
// than the intrinsic heights of the inner elements.
// - Make the height of the container element equal to the intrinsic height of
- // the inner elements when the field has a strong password or strong confirmation
- // password button.
+ // the inner elements when the field has a strong password button.
//
// We don't honor paddings and borders for textfields without decorations
// and type=search if the text height is taller than the contentHeight()
Modified: trunk/Source/WebCore/testing/Internals.cpp (233577 => 233578)
--- trunk/Source/WebCore/testing/Internals.cpp 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/testing/Internals.cpp 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1756,8 +1756,6 @@
return AutoFillButtonType::Credentials;
case Internals::AutoFillButtonType::Contacts:
return AutoFillButtonType::Contacts;
- case Internals::AutoFillButtonType::StrongConfirmationPassword:
- return AutoFillButtonType::StrongConfirmationPassword;
case Internals::AutoFillButtonType::StrongPassword:
return AutoFillButtonType::StrongPassword;
}
@@ -1774,9 +1772,7 @@
return Internals::AutoFillButtonType::Credentials;
case AutoFillButtonType::Contacts:
return Internals::AutoFillButtonType::Contacts;
- case AutoFillButtonType::StrongConfirmationPassword:
- return Internals::AutoFillButtonType::StrongConfirmationPassword;
- case AutoFillButtonType::StrongPassword:
+ case AutoFillButtonType::StrongPassword:
return Internals::AutoFillButtonType::StrongPassword;
}
ASSERT_NOT_REACHED();
Modified: trunk/Source/WebCore/testing/Internals.h (233577 => 233578)
--- trunk/Source/WebCore/testing/Internals.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/testing/Internals.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -245,7 +245,7 @@
bool elementShouldAutoComplete(HTMLInputElement&);
void setEditingValue(HTMLInputElement&, const String&);
void setAutofilled(HTMLInputElement&, bool enabled);
- enum class AutoFillButtonType { None, Contacts, Credentials, StrongPassword, StrongConfirmationPassword };
+ enum class AutoFillButtonType { None, Contacts, Credentials, StrongPassword };
void setShowAutoFillButton(HTMLInputElement&, AutoFillButtonType);
AutoFillButtonType autoFillButtonType(const HTMLInputElement&);
AutoFillButtonType lastAutoFillButtonType(const HTMLInputElement&);
Modified: trunk/Source/WebCore/testing/Internals.idl (233577 => 233578)
--- trunk/Source/WebCore/testing/Internals.idl 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebCore/testing/Internals.idl 2018-07-06 16:29:40 UTC (rev 233578)
@@ -62,8 +62,7 @@
"None",
"Contacts",
"Credentials",
- "StrongPassword",
- "StrongConfirmationPassword"
+ "StrongPassword"
};
enum UserInterfaceLayoutDirection {
Modified: trunk/Source/WebKit/ChangeLog (233577 => 233578)
--- trunk/Source/WebKit/ChangeLog 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebKit/ChangeLog 2018-07-06 16:29:40 UTC (rev 233578)
@@ -1,3 +1,22 @@
+2018-07-06 Daniel Bates <[email protected]>
+
+ Remove Strong Confirmation Password button
+ https://bugs.webkit.org/show_bug.cgi?id=187306
+ <rdar://problem/41795185>
+
+ Reviewed by Sam Weinig.
+
+ Remove support for the Strong Confirmation Password button because we never made use of it.
+
+ * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
+ (toAutoFillButtonType):
+ (toWKAutoFillButtonType):
+ * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
+ * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
+ (toAutoFillButtonType):
+ (toWKAutoFillButtonType):
+ * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
+
2018-07-05 Youenn Fablet <[email protected]>
REGRESSION (r230843): Flash doesn't work; Produces blue box on page
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm (233577 => 233578)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm 2018-07-06 16:29:40 UTC (rev 233578)
@@ -135,8 +135,6 @@
return WebCore::AutoFillButtonType::Contacts;
case _WKAutoFillButtonTypeCredentials:
return WebCore::AutoFillButtonType::Credentials;
- case _WKAutoFillButtonTypeStrongConfirmationPassword:
- return WebCore::AutoFillButtonType::StrongConfirmationPassword;
case _WKAutoFillButtonTypeStrongPassword:
return WebCore::AutoFillButtonType::StrongPassword;
}
@@ -153,8 +151,6 @@
return _WKAutoFillButtonTypeContacts;
case WebCore::AutoFillButtonType::Credentials:
return _WKAutoFillButtonTypeCredentials;
- case WebCore::AutoFillButtonType::StrongConfirmationPassword:
- return _WKAutoFillButtonTypeStrongConfirmationPassword;
case WebCore::AutoFillButtonType::StrongPassword:
return _WKAutoFillButtonTypeStrongPassword;
}
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h (233577 => 233578)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -31,7 +31,6 @@
_WKAutoFillButtonTypeNone,
_WKAutoFillButtonTypeCredentials,
_WKAutoFillButtonTypeContacts,
- _WKAutoFillButtonTypeStrongConfirmationPassword,
_WKAutoFillButtonTypeStrongPassword,
} WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp (233577 => 233578)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp 2018-07-06 16:29:40 UTC (rev 233578)
@@ -46,8 +46,6 @@
return WebCore::AutoFillButtonType::Contacts;
case kWKAutoFillButtonTypeCredentials:
return WebCore::AutoFillButtonType::Credentials;
- case kWKAutoFillButtonTypeStrongConfirmationPassword:
- return WebCore::AutoFillButtonType::StrongConfirmationPassword;
case kWKAutoFillButtonTypeStrongPassword:
return WebCore::AutoFillButtonType::StrongPassword;
}
@@ -64,8 +62,6 @@
return kWKAutoFillButtonTypeContacts;
case WebCore::AutoFillButtonType::Credentials:
return kWKAutoFillButtonTypeCredentials;
- case WebCore::AutoFillButtonType::StrongConfirmationPassword:
- return kWKAutoFillButtonTypeStrongConfirmationPassword;
case WebCore::AutoFillButtonType::StrongPassword:
return kWKAutoFillButtonTypeStrongPassword;
}
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h (233577 => 233578)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h 2018-07-06 11:49:39 UTC (rev 233577)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h 2018-07-06 16:29:40 UTC (rev 233578)
@@ -40,7 +40,6 @@
kWKAutoFillButtonTypeCredentials,
kWKAutoFillButtonTypeContacts,
kWKAutoFillButtonTypeStrongPassword,
- kWKAutoFillButtonTypeStrongConfirmationPassword,
};
typedef uint8_t WKAutoFillButtonType;
