Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (233585 => 233586)
--- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-07-06 18:43:57 UTC (rev 233585)
+++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2018-07-06 19:24:59 UTC (rev 233586)
@@ -69,6 +69,7 @@
def __init__(self, platform, configuration='release', architectures=None, additionalArguments=None, **kwargs):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
self.addStep(CompileJSCOnly())
+ self.addStep(RunJavaScriptCoreTests())
class GTKFactory(Factory):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (233585 => 233586)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-07-06 18:43:57 UTC (rev 233585)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-07-06 19:24:59 UTC (rev 233586)
@@ -156,6 +156,20 @@
command = ["perl", "Tools/Scripts/build-jsc", WithProperties("--%(configuration)s")]
+class RunJavaScriptCoreTests(shell.Test):
+ name = 'jscore-test'
+ description = ['jscore-tests running']
+ descriptionDone = ['jscore-tests']
+ flunkOnFailure = True
+ jsonFileName = 'jsc_results.json'
+ logfiles = {"json": jsonFileName}
+ command = ['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(jsonFileName), WithProperties('--%(configuration)s')]
+
+ def start(self):
+ appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
+ return shell.Test.start(self)
+
+
class CleanBuild(shell.Compile):
name = "delete-WebKitBuild-directory"
description = ["deleting WebKitBuild directory"]
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (233585 => 233586)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-07-06 18:43:57 UTC (rev 233585)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-07-06 19:24:59 UTC (rev 233586)
@@ -480,5 +480,44 @@
return self.runStep()
+class TestRunJavaScriptCoreTests(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ self.longMessage = True
+ self.jsonFileName = 'jsc_results.json'
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_success(self):
+ self.setupStep(RunJavaScriptCoreTests())
+ self.setProperty('fullPlatform', 'jsc-only')
+ self.setProperty('configuration', 'release')
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release'],
+ logfiles={'json': self.jsonFileName},
+ )
+ + 0,
+ )
+ self.expectOutcome(result=SUCCESS, state_string='jscore-tests')
+ return self.runStep()
+
+ def test_failure(self):
+ self.setupStep(RunJavaScriptCoreTests())
+ self.setProperty('fullPlatform', 'jsc-only')
+ self.setProperty('configuration', 'debug')
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--debug'],
+ logfiles={'json': self.jsonFileName},
+ )
+ + ExpectShell.log('stdio', stdout='9 failures found.')
+ + 2,
+ )
+ self.expectOutcome(result=FAILURE, state_string='jscore-tests (failure)')
+ return self.runStep()
+
+
if __name__ == '__main__':
unittest.main()
Modified: trunk/Tools/ChangeLog (233585 => 233586)
--- trunk/Tools/ChangeLog 2018-07-06 18:43:57 UTC (rev 233585)
+++ trunk/Tools/ChangeLog 2018-07-06 19:24:59 UTC (rev 233586)
@@ -1,3 +1,14 @@
+2018-07-06 Aakash Jain <[email protected]>
+
+ [ews-build] EWS should run _javascript_core tests
+ https://bugs.webkit.org/show_bug.cgi?id=187365
+
+ Reviewed by David Kilzer.
+
+ * BuildSlaveSupport/ews-build/steps.py: Added step to run _javascript_CoreTests.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
+ * BuildSlaveSupport/ews-build/factories.py:
+
2018-07-06 Carlos Garcia Campos <[email protected]>
[GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
