Title: [233598] trunk/Source/WebKit
- Revision
- 233598
- Author
- [email protected]
- Date
- 2018-07-06 15:23:56 -0700 (Fri, 06 Jul 2018)
Log Message
ASSERTION FAILED: contextConnection under WebCore::SWServer::terminateWorkerInternal
https://bugs.webkit.org/show_bug.cgi?id=187348
<rdar://problem/41853270>
Reviewed by Youenn Fablet.
Make sure we mark corresponding SWServerWorkers as terminated when we terminate a
Service Worker context connection once it is no longer needed.
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::swContextConnectionMayNoLongerBeNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233597 => 233598)
--- trunk/Source/WebKit/ChangeLog 2018-07-06 22:22:06 UTC (rev 233597)
+++ trunk/Source/WebKit/ChangeLog 2018-07-06 22:23:56 UTC (rev 233598)
@@ -1,3 +1,17 @@
+2018-07-06 Chris Dumez <[email protected]>
+
+ ASSERTION FAILED: contextConnection under WebCore::SWServer::terminateWorkerInternal
+ https://bugs.webkit.org/show_bug.cgi?id=187348
+ <rdar://problem/41853270>
+
+ Reviewed by Youenn Fablet.
+
+ Make sure we mark corresponding SWServerWorkers as terminated when we terminate a
+ Service Worker context connection once it is no longer needed.
+
+ * StorageProcess/StorageProcess.cpp:
+ (WebKit::StorageProcess::swContextConnectionMayNoLongerBeNeeded):
+
2018-07-06 Andy Estes <[email protected]>
[iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle
Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.cpp (233597 => 233598)
--- trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2018-07-06 22:22:06 UTC (rev 233597)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2018-07-06 22:23:56 UTC (rev 233598)
@@ -554,6 +554,9 @@
RELEASE_LOG(ServiceWorker, "Service worker process is no longer needed, terminating it");
serverToContextConnection.terminate();
+ for (auto& swServer : m_swServers.values())
+ swServer->markAllWorkersForOriginAsTerminated(securityOrigin);
+
serverToContextConnection.connectionClosed();
m_serverToContextConnections.remove(securityOrigin);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
