Title: [233607] trunk
- Revision
- 233607
- Author
- n_w...@apple.com
- Date
- 2018-07-06 17:34:40 -0700 (Fri, 06 Jul 2018)
Log Message
AX: add a subrole for meter elements on macOS
https://bugs.webkit.org/show_bug.cgi?id=187409
<rdar://problem/41905702>
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/mac/meter-subrole.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
* accessibility/mac/meter-subrole-expected.txt: Added.
* accessibility/mac/meter-subrole.html: Added.
* platform/mac/accessibility/roles-exposed-expected.txt:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233606 => 233607)
--- trunk/LayoutTests/ChangeLog 2018-07-07 00:32:48 UTC (rev 233606)
+++ trunk/LayoutTests/ChangeLog 2018-07-07 00:34:40 UTC (rev 233607)
@@ -1,3 +1,15 @@
+2018-07-06 Nan Wang <n_w...@apple.com>
+
+ AX: add a subrole for meter elements on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=187409
+ <rdar://problem/41905702>
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/meter-subrole-expected.txt: Added.
+ * accessibility/mac/meter-subrole.html: Added.
+ * platform/mac/accessibility/roles-exposed-expected.txt:
+
2018-07-06 Youenn Fablet <you...@apple.com>
WebRTC MediaStreamTrack Enable / Disable causes video delay / lag
Added: trunk/LayoutTests/accessibility/mac/meter-subrole-expected.txt (0 => 233607)
--- trunk/LayoutTests/accessibility/mac/meter-subrole-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/mac/meter-subrole-expected.txt 2018-07-07 00:34:40 UTC (rev 233607)
@@ -0,0 +1,11 @@
+
+This tests the subrole for meter elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS meter.subrole is 'AXSubrole: AXMeter'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/accessibility/mac/meter-subrole.html (0 => 233607)
--- trunk/LayoutTests/accessibility/mac/meter-subrole.html (rev 0)
+++ trunk/LayoutTests/accessibility/mac/meter-subrole.html 2018-07-07 00:34:40 UTC (rev 233607)
@@ -0,0 +1,25 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<meter id="meter" value="83.5"></meter>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+ description("This tests the subrole for meter elements.");
+
+ if (window.accessibilityController) {
+
+ var meter = accessibilityController.accessibleElementById("meter");
+ shouldBe("meter.subrole", "'AXSubrole: AXMeter'");
+ }
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (233606 => 233607)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2018-07-07 00:32:48 UTC (rev 233606)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2018-07-07 00:34:40 UTC (rev 233607)
@@ -531,7 +531,7 @@
meter
AXRole: AXProgressIndicator
- AXSubrole:
+ AXSubrole: AXMeter
AXRoleDescription: progress indicator
nav
Modified: trunk/Source/WebCore/ChangeLog (233606 => 233607)
--- trunk/Source/WebCore/ChangeLog 2018-07-07 00:32:48 UTC (rev 233606)
+++ trunk/Source/WebCore/ChangeLog 2018-07-07 00:34:40 UTC (rev 233607)
@@ -1,3 +1,16 @@
+2018-07-06 Nan Wang <n_w...@apple.com>
+
+ AX: add a subrole for meter elements on macOS
+ https://bugs.webkit.org/show_bug.cgi?id=187409
+ <rdar://problem/41905702>
+
+ Reviewed by Chris Fleizach.
+
+ Test: accessibility/mac/meter-subrole.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper subrole]):
+
2018-07-06 Jeremy Jones <jere...@apple.com>
For <video> element, use video fullscreen instead of element fullscreen.
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (233606 => 233607)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2018-07-07 00:32:48 UTC (rev 233606)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2018-07-07 00:34:40 UTC (rev 233607)
@@ -2049,6 +2049,9 @@
return [attachView accessibilityAttributeValue:NSAccessibilitySubroleAttribute];
}
+ if (m_object->isMeter())
+ return @"AXMeter";
+
AccessibilityRole role = m_object->roleValue();
if (role == AccessibilityRole::HorizontalRule)
return NSAccessibilityContentSeparatorSubrole;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
