Title: [233617] branches/safari-606.1.24-branch/Source/WebKit
- Revision
- 233617
- Author
- [email protected]
- Date
- 2018-07-07 11:38:04 -0700 (Sat, 07 Jul 2018)
Log Message
Cherry-pick r233616. rdar://problem/41931915
REGRESSION (r233561): MobileMail crashes when replying to an email
https://bugs.webkit.org/show_bug.cgi?id=187436
rdar://problem/41931915
Reviewed by Alan Bujtas.
r233561 added a RELEASE_ASSERT(isMainThread()) in this function. This is fine most of the time,
until Mail spawns a WebThread for mail compose, at which point the meaning of isMainThread changes
and the RELEASE_ASSERT fires.
For now, just remove the RELEASE_ASSERT.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606.1.24-branch/Source/WebKit/ChangeLog (233616 => 233617)
--- branches/safari-606.1.24-branch/Source/WebKit/ChangeLog 2018-07-07 17:50:54 UTC (rev 233616)
+++ branches/safari-606.1.24-branch/Source/WebKit/ChangeLog 2018-07-07 18:38:04 UTC (rev 233617)
@@ -1,3 +1,41 @@
+2018-07-07 Babak Shafiei <[email protected]>
+
+ Cherry-pick r233616. rdar://problem/41931915
+
+ REGRESSION (r233561): MobileMail crashes when replying to an email
+ https://bugs.webkit.org/show_bug.cgi?id=187436
+ rdar://problem/41931915
+
+ Reviewed by Alan Bujtas.
+
+ r233561 added a RELEASE_ASSERT(isMainThread()) in this function. This is fine most of the time,
+ until Mail spawns a WebThread for mail compose, at which point the meaning of isMainThread changes
+ and the RELEASE_ASSERT fires.
+
+ For now, just remove the RELEASE_ASSERT.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-07 Simon Fraser <[email protected]>
+
+ REGRESSION (r233561): MobileMail crashes when replying to an email
+ https://bugs.webkit.org/show_bug.cgi?id=187436
+ rdar://problem/41931915
+
+ Reviewed by Alan Bujtas.
+
+ r233561 added a RELEASE_ASSERT(isMainThread()) in this function. This is fine most of the time,
+ until Mail spawns a WebThread for mail compose, at which point the meaning of isMainThread changes
+ and the RELEASE_ASSERT fires.
+
+ For now, just remove the RELEASE_ASSERT.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
+
2018-07-06 Babak Shafiei <[email protected]>
Cherry-pick r233561. rdar://problem/41878797
Modified: branches/safari-606.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (233616 => 233617)
--- branches/safari-606.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-07-07 17:50:54 UTC (rev 233616)
+++ branches/safari-606.1.24-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-07-07 18:38:04 UTC (rev 233617)
@@ -2736,8 +2736,6 @@
- (void)_scheduleVisibleContentRectUpdateAfterScrollInView:(UIScrollView *)scrollView
{
- RELEASE_ASSERT(isMainThread());
-
_visibleContentRectUpdateScheduledFromScrollViewInStableState = [self _scrollViewIsInStableState:scrollView];
if (_hasScheduledVisibleRectUpdate) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
