Title: [233624] trunk/Tools
Revision
233624
Author
[email protected]
Date
2018-07-07 15:29:08 -0700 (Sat, 07 Jul 2018)

Log Message

WPT importer should create dummy HTML files for *.window.js script files
https://bugs.webkit.org/show_bug.cgi?id=187426

Reviewed by Ryosuke Niwa.

Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
Do the same strategy as done for worker.js/any.js files.

* Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.write_html_files_for_templated_js_tests):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (233623 => 233624)


--- trunk/Tools/ChangeLog	2018-07-07 21:05:45 UTC (rev 233623)
+++ trunk/Tools/ChangeLog	2018-07-07 22:29:08 UTC (rev 233624)
@@ -1,3 +1,16 @@
+2018-07-07  Youenn Fablet  <[email protected]>
+
+        WPT importer should create dummy HTML files for *.window.js script files
+        https://bugs.webkit.org/show_bug.cgi?id=187426
+
+        Reviewed by Ryosuke Niwa.
+
+        Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
+        Do the same strategy as done for worker.js/any.js files.
+
+        * Scripts/webkitpy/w3c/test_importer.py:
+        (TestImporter.write_html_files_for_templated_js_tests):
+
 2018-07-07  Wenson Hsieh  <[email protected]>
 
         Introduce a layout milestone to track when the document contains a large number of rendered characters

Modified: trunk/Tools/Scripts/webkitpy/w3c/test_importer.py (233623 => 233624)


--- trunk/Tools/Scripts/webkitpy/w3c/test_importer.py	2018-07-07 21:05:45 UTC (rev 233623)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_importer.py	2018-07-07 22:29:08 UTC (rev 233624)
@@ -362,6 +362,9 @@
 
     def write_html_files_for_templated_js_tests(self, orig_filepath, new_filepath):
         content = '<!-- This file is required for WebKit test infrastructure to run the templated test -->'
+        if (orig_filepath.endswith('.window.js')):
+            self.filesystem.write_text_file(new_filepath.replace('.window.js', '.window.html'), content)
+            return
         if (orig_filepath.endswith('.worker.js')):
             self.filesystem.write_text_file(new_filepath.replace('.worker.js', '.worker.html'), content)
             return
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to