Title: [233637] trunk/Source/WebCore
- Revision
- 233637
- Author
- [email protected]
- Date
- 2018-07-09 01:15:30 -0700 (Mon, 09 Jul 2018)
Log Message
[GStreamer] Remove useless workaround
https://bugs.webkit.org/show_bug.cgi?id=186921
Reviewed by Xabier Rodriguez-Calvar.
In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
the media/video-reverse-play-duration.html test passes without any
workaround needed. The other test mentioned in that bug was
removed, it seems.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
Removed early return, position queries shouldn't be avoided on EOS
because the pipeline is in READY state, not NULL.
(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (233636 => 233637)
--- trunk/Source/WebCore/ChangeLog 2018-07-09 05:57:01 UTC (rev 233636)
+++ trunk/Source/WebCore/ChangeLog 2018-07-09 08:15:30 UTC (rev 233637)
@@ -1,3 +1,21 @@
+2018-07-09 Philippe Normand <[email protected]>
+
+ [GStreamer] Remove useless workaround
+ https://bugs.webkit.org/show_bug.cgi?id=186921
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
+ the media/video-reverse-play-duration.html test passes without any
+ workaround needed. The other test mentioned in that bug was
+ removed, it seems.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
+ Removed early return, position queries shouldn't be avoided on EOS
+ because the pipeline is in READY state, not NULL.
+ (WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
+
2018-07-08 Simon Fraser <[email protected]>
Optimize packing of RenderSVGViewportContainer
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (233636 => 233637)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-07-09 05:57:01 UTC (rev 233636)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2018-07-09 08:15:30 UTC (rev 233637)
@@ -334,18 +334,9 @@
MediaTime MediaPlayerPrivateGStreamer::playbackPosition() const
{
- if (m_isEndReached) {
- // Position queries on a null pipeline return 0. If we're at
- // the end of the stream the pipeline is null but we want to
- // report either the seek time or the duration because this is
- // what the Media element spec expects us to do.
- if (m_seeking)
- return m_seekTime;
+ if (m_isEndReached && m_seeking)
+ return m_seekTime;
- MediaTime duration = durationMediaTime();
- return duration.isInvalid() ? MediaTime::zeroTime() : duration;
- }
-
// Position is only available if no async state change is going on and the state is either paused or playing.
gint64 position = GST_CLOCK_TIME_NONE;
GstQuery* query = gst_query_new_position(GST_FORMAT_TIME);
@@ -487,14 +478,6 @@
if (m_seeking)
return m_seekTime;
- // Workaround for
- // https://bugzilla.gnome.org/show_bug.cgi?id=639941 In GStreamer
- // 0.10.35 basesink reports wrong duration in case of EOS and
- // negative playback rate. There's no upstream accepted patch for
- // this bug yet, hence this temporary workaround.
- if (m_isEndReached && m_playbackRate < 0)
- return MediaTime::invalidTime();
-
return playbackPosition();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
