Title: [233641] trunk/Source/WebKit
- Revision
- 233641
- Author
- [email protected]
- Date
- 2018-07-09 09:30:37 -0700 (Mon, 09 Jul 2018)
Log Message
WebDriver: hang in Selenium test alerts_tests.py::testShouldHandleAlertOnPageBeforeUnload
https://bugs.webkit.org/show_bug.cgi?id=187418
<rdar://problem/41909520>
Unreviewed build fix for Sierra.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
According to some compilers, the local 'automationSession' is unused. Change this
to just convert the return value to boolean rather than assign to an unused local.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233640 => 233641)
--- trunk/Source/WebKit/ChangeLog 2018-07-09 15:18:08 UTC (rev 233640)
+++ trunk/Source/WebKit/ChangeLog 2018-07-09 16:30:37 UTC (rev 233641)
@@ -1,3 +1,16 @@
+2018-07-09 Brian Burg <[email protected]>
+
+ WebDriver: hang in Selenium test alerts_tests.py::testShouldHandleAlertOnPageBeforeUnload
+ https://bugs.webkit.org/show_bug.cgi?id=187418
+ <rdar://problem/41909520>
+
+ Unreviewed build fix for Sierra.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
+ According to some compilers, the local 'automationSession' is unused. Change this
+ to just convert the return value to boolean rather than assign to an unused local.
+
2018-07-07 Wenson Hsieh <[email protected]>
Introduce a layout milestone to track when the document contains a large number of rendered characters
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (233640 => 233641)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-07-09 15:18:08 UTC (rev 233640)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-07-09 16:30:37 UTC (rev 233641)
@@ -4527,7 +4527,7 @@
// event handlers, are dismissed implicitly upon navigation or close window, regardless of the
// defined user prompt handler." So, always allow the unload to proceed if the page is being automated.
if (m_controlledByAutomation) {
- if (auto* automationSession = process().processPool().automationSession()) {
+ if (!!process().processPool().automationSession()) {
reply(true);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
