Title: [233656] trunk/LayoutTests
- Revision
- 233656
- Author
- [email protected]
- Date
- 2018-07-09 13:48:20 -0700 (Mon, 09 Jul 2018)
Log Message
This test is *still* flaky. This unreviewed patch is my attempt to make it less so.
* storage/indexeddb/modern/opendatabase-after-storage-crash.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (233655 => 233656)
--- trunk/LayoutTests/ChangeLog 2018-07-09 20:00:32 UTC (rev 233655)
+++ trunk/LayoutTests/ChangeLog 2018-07-09 20:48:20 UTC (rev 233656)
@@ -1,3 +1,9 @@
+2018-07-09 Brady Eidson <[email protected]>
+
+ This test is *still* flaky. This unreviewed patch is my attempt to make it less so.
+
+ * storage/indexeddb/modern/opendatabase-after-storage-crash.html:
+
2018-07-09 Brian Burg <[email protected]>
REGRESSION: Web Inspector no longer pauses in internal injected scripts like WDFindNodes.js
Modified: trunk/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html (233655 => 233656)
--- trunk/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html 2018-07-09 20:00:32 UTC (rev 233655)
+++ trunk/LayoutTests/storage/indexeddb/modern/opendatabase-after-storage-crash.html 2018-07-09 20:48:20 UTC (rev 233656)
@@ -6,6 +6,7 @@
<script>
var dbname = setDBNameFromPath() + Date();
+var storageKey = "opendatabase-after-storage-crash.html";
function continueTest()
{
@@ -20,7 +21,7 @@
request._onerror_ = function(e) {
// Good, we received an expected error.
// Now reload to see if a new document connects successfully
- if (sessionStorage[location.href]) {
+ if (sessionStorage[storageKey]) {
document.body.innerHTML = "Should not have reached this code twice!";
if (window.testRunner)
testRunner.notifyDone();
@@ -27,22 +28,23 @@
return;
}
- sessionStorage[location.href] = "Made it";
+ sessionStorage[storageKey] = "Made it";
location.reload();
}
request._onsuccess_ = function(e) {
- document.body.innerHTML = "Unexpected success during the second database open after document load. " + sessionStorage[location.href];
+ document.body.innerHTML = "Unexpected success during the second database open after document load. SessionStorage value: " + sessionStorage[storageKey];
if (window.testRunner)
testRunner.notifyDone();
}
}
-var request = window.indexedDB.open(dbname, 1);
+var versionToOpen = sessionStorage.finishedFirstOpen ? 3 : 1;
+var request = window.indexedDB.open(dbname, versionToOpen);
request._onupgradeneeded_ = function(e) {
if (sessionStorage.finishedFirstOpen) {
document.body.innerHTML = "";
- if (sessionStorage[location.href] != "Made it")
+ if (sessionStorage[storageKey] != "Made it")
document.body.innerHTML += "Expected error in the first pass of the test was NOT logged<br>";
document.body.innerHTML += "Successfully opened the database in a new document"
if (window.testRunner)
@@ -61,13 +63,13 @@
}
request._onerror_ = function(e) {
- document.body.innerHTML = "Unexpected error during the first database open on document load. " + sessionStorage[location.href];
+ document.body.innerHTML = "Unexpected error during the first database open on document load. Message: " + e.message + ". Version opening: " + versionToOpen + ". SessionStorage value: " + sessionStorage[storageKey];
if (window.testRunner)
testRunner.notifyDone();
}
request._onsuccess_ = function(e) {
- document.body.innerHTML = "Unexpected success during the first database open on document load. " + sessionStorage[location.href];
+ document.body.innerHTML = "Unexpected success during the first database open on document load. Version opening: " + versionToOpen + ". SessionStorage value: " + sessionStorage[storageKey];
if (window.testRunner)
testRunner.notifyDone();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
