Title: [233681] trunk/Tools
- Revision
- 233681
- Author
- [email protected]
- Date
- 2018-07-10 03:15:00 -0700 (Tue, 10 Jul 2018)
Log Message
[Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
https://bugs.webkit.org/show_bug.cgi?id=187470
Patch by Thibault Saunier <[email protected]> on 2018-07-10
Reviewed by Philippe Normand.
Never force building, the user is responsible to make that decision and the workflow is
now based on external scripts so it doesn't make sense anymore. Doing that leads
to ignoring the options the user passed in.
* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_dev_env):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233680 => 233681)
--- trunk/Tools/ChangeLog 2018-07-10 08:23:53 UTC (rev 233680)
+++ trunk/Tools/ChangeLog 2018-07-10 10:15:00 UTC (rev 233681)
@@ -1,5 +1,19 @@
2018-07-10 Thibault Saunier <[email protected]>
+ [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
+ https://bugs.webkit.org/show_bug.cgi?id=187470
+
+ Reviewed by Philippe Normand.
+
+ Never force building, the user is responsible to make that decision and the workflow is
+ now based on external scripts so it doesn't make sense anymore. Doing that leads
+ to ignoring the options the user passed in.
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak.setup_dev_env):
+
+2018-07-10 Thibault Saunier <[email protected]>
+
[Flatpak] Fix running wpt tests inside flatpak
https://bugs.webkit.org/show_bug.cgi?id=187490
Modified: trunk/Tools/flatpak/flatpakutils.py (233680 => 233681)
--- trunk/Tools/flatpak/flatpakutils.py 2018-07-10 08:23:53 UTC (rev 233680)
+++ trunk/Tools/flatpak/flatpakutils.py 2018-07-10 10:15:00 UTC (rev 233681)
@@ -760,9 +760,6 @@
builder_args.append("--stop-at=%s" % self.name)
subprocess.check_call(builder_args)
- if not self.update and not os.path.exists(os.path.join(self.build_path, "bin", "MiniBrowser")):
- self.build_webkit = True
-
if self.build_webkit:
builder = [os.path.join(self.sandbox_source_root, 'Tools/Scripts/build-webkit'),
"--debug" if self.debug else "--release", '--' + self.platform.lower()]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
