Title: [233746] trunk/Source/WebKit
- Revision
- 233746
- Author
- commit-qu...@webkit.org
- Date
- 2018-07-11 17:08:39 -0700 (Wed, 11 Jul 2018)
Log Message
Unreviewed, rolling out r233741.
https://bugs.webkit.org/show_bug.cgi?id=187568
"WKTR vs exp features, booooooo" (Requested by bradee-oh on
#webkit).
Reverted changeset:
"Make process-swap-on-navigation an experimental feature."
https://bugs.webkit.org/show_bug.cgi?id=187558
https://trac.webkit.org/changeset/233741
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233745 => 233746)
--- trunk/Source/WebKit/ChangeLog 2018-07-11 23:30:28 UTC (rev 233745)
+++ trunk/Source/WebKit/ChangeLog 2018-07-12 00:08:39 UTC (rev 233746)
@@ -1,3 +1,17 @@
+2018-07-11 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r233741.
+ https://bugs.webkit.org/show_bug.cgi?id=187568
+
+ "WKTR vs exp features, booooooo" (Requested by bradee-oh on
+ #webkit).
+
+ Reverted changeset:
+
+ "Make process-swap-on-navigation an experimental feature."
+ https://bugs.webkit.org/show_bug.cgi?id=187558
+ https://trac.webkit.org/changeset/233741
+
2018-07-11 Brady Eidson <beid...@apple.com>
Make process-swap-on-navigation an experimental feature.
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (233745 => 233746)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-07-11 23:30:28 UTC (rev 233745)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-07-12 00:08:39 UTC (rev 233746)
@@ -1283,12 +1283,3 @@
webcoreBinding: RuntimeEnabledFeatures
category: experimental
condition: ENABLE(ENCRYPTED_MEDIA)
-
-ProcessSwapOnNavigationEnabled:
- type: bool
- defaultValue: false
- humanReadableName: "Swap Processes on Navigation"
- humanReadableDescription: "Swap WebContent processes on cross-origin navigations"
- category: experimental
- webcoreBinding: none
-
Modified: trunk/Source/WebKit/UIProcess/WebPreferences.cpp (233745 => 233746)
--- trunk/Source/WebKit/UIProcess/WebPreferences.cpp 2018-07-11 23:30:28 UTC (rev 233745)
+++ trunk/Source/WebKit/UIProcess/WebPreferences.cpp 2018-07-12 00:08:39 UTC (rev 233746)
@@ -133,13 +133,6 @@
void WebPreferences::updateBoolValueForExperimentalFeatureKey(const String& key, bool value)
{
- if (key == WebPreferencesKey::processSwapOnNavigationEnabledKey()) {
- for (auto* page : m_pages)
- page->process().processPool().configuration().setProcessSwapsOnNavigation(value);
-
- return;
- }
-
update(); // FIXME: Only send over the changed key and value.
}
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (233745 => 233746)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-07-11 23:30:28 UTC (rev 233745)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-07-12 00:08:39 UTC (rev 233746)
@@ -1149,11 +1149,7 @@
ASSERT(!is<ServiceWorkerProcessProxy>(*process));
#endif
- auto page = process->createWebPage(pageClient, WTFMove(pageConfiguration));
- if (page->preferences().processSwapOnNavigationEnabled())
- m_configuration->setProcessSwapsOnNavigation(true);
-
- return page;
+ return process->createWebPage(pageClient, WTFMove(pageConfiguration));
}
#if ENABLE(SERVICE_WORKER)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
