Title: [233856] trunk/Tools
- Revision
- 233856
- Author
- [email protected]
- Date
- 2018-07-16 11:52:22 -0700 (Mon, 16 Jul 2018)
Log Message
Add --target-path option to dump-class-layout
https://bugs.webkit.org/show_bug.cgi?id=187687
Reviewed by Simon Fraser.
We add an escape hatch to dump-class-layout for specifying target path directly.
This `--target-path` allows us to use dump-class-layout in the other ports
like JSCOnly.
We can dump class layout if we build the target with clang by using the following command.
Tools/Scripts/dump-class-layout \
--architecture=x86_64 \
--target-path=path/to/libJavaScriptCore.so \
_javascript_Core \
ScopeNode
* Scripts/dump-class-layout:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233855 => 233856)
--- trunk/Tools/ChangeLog 2018-07-16 18:49:22 UTC (rev 233855)
+++ trunk/Tools/ChangeLog 2018-07-16 18:52:22 UTC (rev 233856)
@@ -1,3 +1,25 @@
+2018-07-16 Yusuke Suzuki <[email protected]>
+
+ Add --target-path option to dump-class-layout
+ https://bugs.webkit.org/show_bug.cgi?id=187687
+
+ Reviewed by Simon Fraser.
+
+ We add an escape hatch to dump-class-layout for specifying target path directly.
+ This `--target-path` allows us to use dump-class-layout in the other ports
+ like JSCOnly.
+
+ We can dump class layout if we build the target with clang by using the following command.
+
+ Tools/Scripts/dump-class-layout \
+ --architecture=x86_64 \
+ --target-path=path/to/libJavaScriptCore.so \
+ _javascript_Core \
+ ScopeNode
+
+ * Scripts/dump-class-layout:
+ (main):
+
2018-07-16 Sihui Liu <[email protected]>
IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
Modified: trunk/Tools/Scripts/dump-class-layout (233855 => 233856)
--- trunk/Tools/Scripts/dump-class-layout 2018-07-16 18:49:22 UTC (rev 233855)
+++ trunk/Tools/Scripts/dump-class-layout 2018-07-16 18:52:22 UTC (rev 233856)
@@ -39,6 +39,7 @@
framework = "WebCore"
build_directory = ""
+target_path = ""
config = "Release"
arch = None
@@ -62,16 +63,22 @@
parser.add_argument('-a', '--architecture', dest='arch', action='',
help='Architecture (i386, x86_64, armv7, armv7s, arm64). Uses the first architecture listed by \'file\' by default')
+ parser.add_argument('-t', '--target-path', dest='target_path', action='',
+ help='Path to the target')
+
args = parser.parse_args()
build_dir = webkit_build_dir()
- if args.config == None:
+ if args.config is None:
args.config = "Release"
- if not args.build_directory == None:
+ if args.build_directory is not None:
build_dir = args.build_directory
- target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework);
+ if args.target_path is not None:
+ target_path = args.target_path
+ else:
+ target_path = os.path.join(build_dir, args.config, args.framework + ".framework", args.framework);
lldb_instance = LLDBDebuggerInstance(target_path, args.arch)
class_layout = lldb_instance.layout_for_classname(args.classname)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
