Title: [233884] trunk/Websites/perf.webkit.org
- Revision
- 233884
- Author
- [email protected]
- Date
- 2018-07-16 22:07:34 -0700 (Mon, 16 Jul 2018)
Log Message
CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
https://bugs.webkit.org/show_bug.cgi?id=187675
Reviewed by Ryosuke Niwa.
This change will fix the bug that no notification will be sent for any test groups except the
first one in any custom perf-try A/B task.
* public/v3/components/custom-configuration-test-group-form.js:
(CustomConfigurationTestGroupForm.prototype.startTesting): Conditionally includes taskName based on
whether or not analysis task is created.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (233883 => 233884)
--- trunk/Websites/perf.webkit.org/ChangeLog 2018-07-17 04:44:23 UTC (rev 233883)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2018-07-17 05:07:34 UTC (rev 233884)
@@ -1,3 +1,17 @@
+2018-07-13 Dewei Zhu <[email protected]>
+
+ CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
+ https://bugs.webkit.org/show_bug.cgi?id=187675
+
+ Reviewed by Ryosuke Niwa.
+
+ This change will fix the bug that no notification will be sent for any test groups except the
+ first one in any custom perf-try A/B task.
+
+ * public/v3/components/custom-configuration-test-group-form.js:
+ (CustomConfigurationTestGroupForm.prototype.startTesting): Conditionally includes taskName based on
+ whether or not analysis task is created.
+
2018-07-03 Dewei Zhu <[email protected]>
MeasurementSet should merge last four segments into two if values are identical.
Modified: trunk/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js (233883 => 233884)
--- trunk/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js 2018-07-17 04:44:23 UTC (rev 233883)
+++ trunk/Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js 2018-07-17 05:07:34 UTC (rev 233884)
@@ -38,7 +38,11 @@
const commitSets = configurator.commitSets();
const platform = configurator.platform();
const test = configurator.tests()[0]; // FIXME: Add the support for specifying multiple tests.
- this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, taskName, this._notifyOnCompletion);
+ console.assert(!!this._hasTask === !taskName);
+ if (!this._hasTask)
+ this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, taskName, this._notifyOnCompletion);
+ else
+ this.dispatchAction('startTesting', this._repetitionCount, testGroupName, commitSets, platform, test, this._notifyOnCompletion);
}
didConstructShadowTree()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
