Title: [233889] trunk/Tools
- Revision
- 233889
- Author
- [email protected]
- Date
- 2018-07-17 11:04:46 -0700 (Tue, 17 Jul 2018)
Log Message
[macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
https://bugs.webkit.org/show_bug.cgi?id=187730
Patch by Aditya Keerthi <[email protected]> on 2018-07-17
Reviewed by Jer Noble.
This regression was introduced by r233865. PIP can now only be initiated from a
window that is on screen.
* TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (233888 => 233889)
--- trunk/Tools/ChangeLog 2018-07-17 17:45:41 UTC (rev 233888)
+++ trunk/Tools/ChangeLog 2018-07-17 18:04:46 UTC (rev 233889)
@@ -1,3 +1,16 @@
+2018-07-17 Aditya Keerthi <[email protected]>
+
+ [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=187730
+
+ Reviewed by Jer Noble.
+
+ This regression was introduced by r233865. PIP can now only be initiated from a
+ window that is on screen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
+ (TestWebKitAPI::TEST):
+
2018-07-17 John Wilander <[email protected]>
Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm (233888 => 233889)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm 2018-07-17 17:45:41 UTC (rev 233888)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm 2018-07-17 18:04:46 UTC (rev 233889)
@@ -122,6 +122,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"PictureInPictureDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
