Title: [233904] trunk/Source/WebKit
- Revision
- 233904
- Author
- [email protected]
- Date
- 2018-07-17 20:43:37 -0700 (Tue, 17 Jul 2018)
Log Message
RELEASE_ASSERT() under IPC::Connection::sendSync() from PluginProxy::supportsSnapshotting()
https://bugs.webkit.org/show_bug.cgi?id=187740
<rdar://problem/41818955>
Reviewed by Youenn Fablet.
As per the crash trace, PluginProxy::supportsSnapshotting() can be called during layout but does synchronous
IPC. As a result, we need to prevent WebCore re-entrancy by using DoNotProcessIncomingMessagesWhenWaitingForSyncReply
sendOption.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::supportsSnapshotting const):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233903 => 233904)
--- trunk/Source/WebKit/ChangeLog 2018-07-18 01:05:29 UTC (rev 233903)
+++ trunk/Source/WebKit/ChangeLog 2018-07-18 03:43:37 UTC (rev 233904)
@@ -1,5 +1,20 @@
2018-07-17 Chris Dumez <[email protected]>
+ RELEASE_ASSERT() under IPC::Connection::sendSync() from PluginProxy::supportsSnapshotting()
+ https://bugs.webkit.org/show_bug.cgi?id=187740
+ <rdar://problem/41818955>
+
+ Reviewed by Youenn Fablet.
+
+ As per the crash trace, PluginProxy::supportsSnapshotting() can be called during layout but does synchronous
+ IPC. As a result, we need to prevent WebCore re-entrancy by using DoNotProcessIncomingMessagesWhenWaitingForSyncReply
+ sendOption.
+
+ * WebProcess/Plugins/PluginProxy.cpp:
+ (WebKit::PluginProxy::supportsSnapshotting const):
+
+2018-07-17 Chris Dumez <[email protected]>
+
Turn on PSON in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=186542
Modified: trunk/Source/WebKit/WebProcess/Plugins/PluginProxy.cpp (233903 => 233904)
--- trunk/Source/WebKit/WebProcess/Plugins/PluginProxy.cpp 2018-07-18 01:05:29 UTC (rev 233903)
+++ trunk/Source/WebKit/WebProcess/Plugins/PluginProxy.cpp 2018-07-18 03:43:37 UTC (rev 233904)
@@ -234,7 +234,7 @@
return false;
bool isSupported = false;
- if (m_connection && !m_connection->connection()->sendSync(Messages::PluginControllerProxy::SupportsSnapshotting(), Messages::PluginControllerProxy::SupportsSnapshotting::Reply(isSupported), m_pluginInstanceID))
+ if (m_connection && !m_connection->connection()->sendSync(Messages::PluginControllerProxy::SupportsSnapshotting(), Messages::PluginControllerProxy::SupportsSnapshotting::Reply(isSupported), m_pluginInstanceID, Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply))
return false;
return isSupported;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
