Title: [101334] trunk/Source/_javascript_Core
- Revision
- 101334
- Author
- [email protected]
- Date
- 2011-11-28 23:57:23 -0800 (Mon, 28 Nov 2011)
Log Message
DFG debugCall() mechanism only works on X86 and X86-64
https://bugs.webkit.org/show_bug.cgi?id=73282
Reviewed by Oliver Hunt.
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101333 => 101334)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-29 07:55:02 UTC (rev 101333)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-29 07:57:23 UTC (rev 101334)
@@ -1,5 +1,15 @@
2011-11-28 Filip Pizlo <[email protected]>
+ DFG debugCall() mechanism only works on X86 and X86-64
+ https://bugs.webkit.org/show_bug.cgi?id=73282
+
+ Reviewed by Oliver Hunt.
+
+ * dfg/DFGAssemblyHelpers.h:
+ (JSC::DFG::AssemblyHelpers::debugCall):
+
+2011-11-28 Filip Pizlo <[email protected]>
+
DFG non-X86 ArithDiv does speculation failure after mutating state,
without a value recovery
https://bugs.webkit.org/show_bug.cgi?id=73286
Modified: trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h (101333 => 101334)
--- trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2011-11-29 07:55:02 UTC (rev 101333)
+++ trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h 2011-11-29 07:57:23 UTC (rev 101334)
@@ -164,7 +164,6 @@
#ifndef NDEBUG
// Add a debug call. This call has no effect on JIT code execution state.
-#if CPU(X86_64) || CPU(X86)
void debugCall(V_DFGDebugOperation_EP function, void* argument)
{
EncodedJSValue* buffer = static_cast<EncodedJSValue*>(m_globalData->scratchBufferForSize(sizeof(EncodedJSValue) * (GPRInfo::numberOfRegisters + FPRInfo::numberOfRegisters)));
@@ -175,7 +174,7 @@
move(TrustedImmPtr(buffer + GPRInfo::numberOfRegisters + i), GPRInfo::regT0);
storeDouble(FPRInfo::toRegister(i), GPRInfo::regT0);
}
-#if CPU(X86_64)
+#if CPU(X86_64) || CPU(ARM_THUMB2)
move(TrustedImmPtr(argument), GPRInfo::argumentGPR1);
move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
#elif CPU(X86)
@@ -193,16 +192,7 @@
for (unsigned i = 0; i < GPRInfo::numberOfRegisters; ++i)
loadPtr(buffer + i, GPRInfo::toRegister(i));
}
-#else
- void debugCall(V_DFGDebugOperation_EP function, void* argument) NO_RETURN_DUE_TO_ASSERT
- {
- // debugCall not supported on this platform.
- UNUSED_PARAM(function);
- UNUSED_PARAM(argument);
- ASSERT_NOT_REACHED();
- }
#endif
-#endif
// These methods JIT generate dynamic, debug-only checks - akin to ASSERTs.
#if DFG_ENABLE(JIT_ASSERT)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
