Title: [233929] trunk/Source/WebKit
- Revision
- 233929
- Author
- [email protected]
- Date
- 2018-07-18 14:15:41 -0700 (Wed, 18 Jul 2018)
Log Message
Crash under WebKit::SuspendedPageProxy::webProcessDidClose(WebKit::WebProcessProxy&)
https://bugs.webkit.org/show_bug.cgi?id=187780
Reviewed by Brady Eidson.
Protect |this| in SuspendedPageProxy::webProcessDidClose() since the call to
WebPageProxy::suspendedPageClosed() may destroy us before the method is done
executing.
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::webProcessDidClose):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (233928 => 233929)
--- trunk/Source/WebKit/ChangeLog 2018-07-18 20:08:00 UTC (rev 233928)
+++ trunk/Source/WebKit/ChangeLog 2018-07-18 21:15:41 UTC (rev 233929)
@@ -1,3 +1,17 @@
+2018-07-18 Chris Dumez <[email protected]>
+
+ Crash under WebKit::SuspendedPageProxy::webProcessDidClose(WebKit::WebProcessProxy&)
+ https://bugs.webkit.org/show_bug.cgi?id=187780
+
+ Reviewed by Brady Eidson.
+
+ Protect |this| in SuspendedPageProxy::webProcessDidClose() since the call to
+ WebPageProxy::suspendedPageClosed() may destroy us before the method is done
+ executing.
+
+ * UIProcess/SuspendedPageProxy.cpp:
+ (WebKit::SuspendedPageProxy::webProcessDidClose):
+
2018-07-18 Jer Noble <[email protected]>
-_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
Modified: trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp (233928 => 233929)
--- trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2018-07-18 20:08:00 UTC (rev 233928)
+++ trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp 2018-07-18 21:15:41 UTC (rev 233929)
@@ -99,6 +99,7 @@
{
ASSERT_UNUSED(process, &process == m_process);
+ auto protectedThis = makeRef(*this);
m_process->processPool().unregisterSuspendedPageProxy(*this);
m_process = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
